wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/deepampriyadarshi_65447610.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

729 行
35 KiB
JSON
原始文件 永久链接 Blame 文件历史

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7708/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7708/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/7708/events",
"html_url": "https://github.com/laurent22/joplin/pull/7708",
"id": 1566265771,
"node_id": "PR_kwDOBLftOs5JBDkU",
"number": 7708,
"title": "Desktop: Resolves #7612 : Fixing Note Viewer theme reset issue on switching HTML to Md note or between 2 HTML notes.",
"user": {
"login": "deepampriyadarshi",
"id": 65447610,
"node_id": "MDQ6VXNlcjY1NDQ3NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/65447610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/deepampriyadarshi",
"html_url": "https://github.com/deepampriyadarshi",
"followers_url": "https://api.github.com/users/deepampriyadarshi/followers",
"following_url": "https://api.github.com/users/deepampriyadarshi/following{/other_user}",
"gists_url": "https://api.github.com/users/deepampriyadarshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/deepampriyadarshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deepampriyadarshi/subscriptions",
"organizations_url": "https://api.github.com/users/deepampriyadarshi/orgs",
"repos_url": "https://api.github.com/users/deepampriyadarshi/repos",
"events_url": "https://api.github.com/users/deepampriyadarshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/deepampriyadarshi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": true,
"assignee": null,
"assignees": [],
"milestone": null,
"comments": 14,
"created_at": "2023-02-01T14:58:01Z",
"updated_at": "2023-02-26T18:02:32Z",
"closed_at": "2023-02-26T17:03:22Z",
"author_association": "NONE",
"sub_issues_summary": {
"total": 0,
"completed": 0,
"percent_completed": 0
},
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/7708",
"html_url": "https://github.com/laurent22/joplin/pull/7708",
"diff_url": "https://github.com/laurent22/joplin/pull/7708.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/7708.patch",
"merged_at": null
},
"body": "Fixes #7612 \r\nThe issue was caused due to the function `addPluginAssets(assets)` in `./packages/app-desktop/gui/note-viewer/index.html` file. One of task of this function was to check loading multiple duplicate css/javascript files while switching between two notes. It works well when two notes share the same css styling (file) but it doesn't removes those css/javascript file links from the DOM tree which was loaded by some other notes and which shouldn't be applied to the current note being viewed. End result => the last appended link node for a css file overwrites the any previously loaded css file belonging to the current note being viewed.\r\n\r\n![image](https://user-images.githubusercontent.com/65447610/216077490-0cbac470-9097-4010-b8ec-0420674a85e3.png)\r\n",
"closed_by": {
"login": "deepampriyadarshi",
"id": 65447610,
"node_id": "MDQ6VXNlcjY1NDQ3NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/65447610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/deepampriyadarshi",
"html_url": "https://github.com/deepampriyadarshi",
"followers_url": "https://api.github.com/users/deepampriyadarshi/followers",
"following_url": "https://api.github.com/users/deepampriyadarshi/following{/other_user}",
"gists_url": "https://api.github.com/users/deepampriyadarshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/deepampriyadarshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deepampriyadarshi/subscriptions",
"organizations_url": "https://api.github.com/users/deepampriyadarshi/orgs",
"repos_url": "https://api.github.com/users/deepampriyadarshi/repos",
"events_url": "https://api.github.com/users/deepampriyadarshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/deepampriyadarshi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/7708/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7708/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1412197660",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1412197660",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1412197660,
"node_id": "IC_kwDOBLftOs5ULG0c",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-01T14:58:19Z",
"updated_at": "2023-02-24T20:02:31Z",
"author_association": "CONTRIBUTOR",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1412197660/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1412201437",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1412201437",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1412201437,
"node_id": "IC_kwDOBLftOs5ULHvd",
"user": {
"login": "deepampriyadarshi",
"id": 65447610,
"node_id": "MDQ6VXNlcjY1NDQ3NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/65447610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/deepampriyadarshi",
"html_url": "https://github.com/deepampriyadarshi",
"followers_url": "https://api.github.com/users/deepampriyadarshi/followers",
"following_url": "https://api.github.com/users/deepampriyadarshi/following{/other_user}",
"gists_url": "https://api.github.com/users/deepampriyadarshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/deepampriyadarshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deepampriyadarshi/subscriptions",
"organizations_url": "https://api.github.com/users/deepampriyadarshi/orgs",
"repos_url": "https://api.github.com/users/deepampriyadarshi/repos",
"events_url": "https://api.github.com/users/deepampriyadarshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/deepampriyadarshi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-01T15:00:37Z",
"updated_at": "2023-02-01T15:00:37Z",
"author_association": "NONE",
"body": "I have read the CLA Document and I hereby sign the CLA",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1412201437/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1416235243",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1416235243",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1416235243,
"node_id": "IC_kwDOBLftOs5Uagjr",
"user": {
"login": "deepampriyadarshi",
"id": 65447610,
"node_id": "MDQ6VXNlcjY1NDQ3NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/65447610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/deepampriyadarshi",
"html_url": "https://github.com/deepampriyadarshi",
"followers_url": "https://api.github.com/users/deepampriyadarshi/followers",
"following_url": "https://api.github.com/users/deepampriyadarshi/following{/other_user}",
"gists_url": "https://api.github.com/users/deepampriyadarshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/deepampriyadarshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deepampriyadarshi/subscriptions",
"organizations_url": "https://api.github.com/users/deepampriyadarshi/orgs",
"repos_url": "https://api.github.com/users/deepampriyadarshi/repos",
"events_url": "https://api.github.com/users/deepampriyadarshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/deepampriyadarshi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-03T18:18:39Z",
"updated_at": "2023-02-03T18:26:50Z",
"author_association": "NONE",
"body": "Hi @tessus, @laurent22 in my first commit all of the checks passed except the `BuildAndroidDebug` one. I tried running commands (`/gradlew assembleDebug`), it worked fine. Also I was able to install it on my phone. And none of my code changes are related to android app. Can we run checks once again to see if it works now? ",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1416235243/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417678927",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1417678927",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1417678927,
"node_id": "IC_kwDOBLftOs5UgBBP",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-05T12:22:07Z",
"updated_at": "2023-02-05T12:22:07Z",
"author_association": "OWNER",
"body": "I think recreating this on each setHtml call might be costly because it's called every time the note changes, so almost every keypress. Isn't it possible to either do this only when changing notes, or to remove the script/css that shouldn't be there?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417678927/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417928233",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1417928233",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1417928233,
"node_id": "IC_kwDOBLftOs5Ug94p",
"user": {
"login": "deepampriyadarshi",
"id": 65447610,
"node_id": "MDQ6VXNlcjY1NDQ3NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/65447610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/deepampriyadarshi",
"html_url": "https://github.com/deepampriyadarshi",
"followers_url": "https://api.github.com/users/deepampriyadarshi/followers",
"following_url": "https://api.github.com/users/deepampriyadarshi/following{/other_user}",
"gists_url": "https://api.github.com/users/deepampriyadarshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/deepampriyadarshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deepampriyadarshi/subscriptions",
"organizations_url": "https://api.github.com/users/deepampriyadarshi/orgs",
"repos_url": "https://api.github.com/users/deepampriyadarshi/repos",
"events_url": "https://api.github.com/users/deepampriyadarshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/deepampriyadarshi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-05T14:01:29Z",
"updated_at": "2023-02-05T14:03:37Z",
"author_association": "NONE",
"body": "> I think recreating this on each setHtml call might be costly because it's called every time the note changes, so almost every keypress. Isn't it possible to either do this only when changing notes, or to remove the script/css that shouldn't be there?\r\n\r\nTrue. I think the process of removing script/css will be equally, if not more, costly since then there would be 2 for loops. One which is already present which goes through assets list and second would be for parsing link nodes. So the former one seems to be a good solution. Also there's one more issue which I found now with the asset list which is passed as the parameter. It has duplicate entries for same CSS files. This only happens when switching between .md files and I think that is why the previous code was checking for any duplicate entries in the asset list. Although it served the purpose of not creating duplicate css/script link node but size of parameter passed keeps increasing on each note switch.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417928233/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417964969",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1417964969",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1417964969,
"node_id": "IC_kwDOBLftOs5UhG2p",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-05T14:25:14Z",
"updated_at": "2023-02-05T14:25:14Z",
"author_association": "OWNER",
"body": "> removing script/css will be equally, if not more, costly since then there would be 2 for loops\r\n\r\nWell, in most cases nothing needs to be added or removed, and looping a JS array costs pretty much nothing in terms of performance. It's adding and removing nodes that's more of a problem.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417964969/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418298729",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1418298729",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1418298729,
"node_id": "IC_kwDOBLftOs5UiYVp",
"user": {
"login": "deepampriyadarshi",
"id": 65447610,
"node_id": "MDQ6VXNlcjY1NDQ3NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/65447610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/deepampriyadarshi",
"html_url": "https://github.com/deepampriyadarshi",
"followers_url": "https://api.github.com/users/deepampriyadarshi/followers",
"following_url": "https://api.github.com/users/deepampriyadarshi/following{/other_user}",
"gists_url": "https://api.github.com/users/deepampriyadarshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/deepampriyadarshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deepampriyadarshi/subscriptions",
"organizations_url": "https://api.github.com/users/deepampriyadarshi/orgs",
"repos_url": "https://api.github.com/users/deepampriyadarshi/repos",
"events_url": "https://api.github.com/users/deepampriyadarshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/deepampriyadarshi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-05T23:41:37Z",
"updated_at": "2023-02-06T09:16:44Z",
"author_association": "NONE",
"body": "> Well, in most cases nothing needs to be added or removed, and looping a JS array costs pretty much nothing in terms of performance. It's adding and removing nodes that's more of a problem.\r\n\r\nThe performance does gets affected if the loop is called on every setHtml (even on single key press) call and on each call the JS array size increases.. Below is the code snippet of the `for loop` that runs through `pluginAssets` array, from current dev branch :- \r\nhttps://github.com/laurent22/joplin/blob/884260189cabef550a55dbe790678e5bdb0e83ed/packages/app-desktop/gui/note-viewer/index.html#L160-L172\r\n\r\n\r\n---\r\nHere a screen recording of what 's happening to the `pluginAssests` array with each setHtml call. Look at the zoomed in section at bottom centre. With just two lines in note, size of array became 90, out of which 73 are duplicate entries of the same file. You can verify from your end too. No doubt that this will stall the rendering as the above loop runs no matter what.\r\n\r\nhttps://user-images.githubusercontent.com/65447610/216852709-41ab3121-403e-4b7e-9974-dc426b6e3d35.mp4\r\n\r\n\r\n\r\n\r\n\r\n\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418298729/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1421009371",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1421009371",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1421009371,
"node_id": "IC_kwDOBLftOs5UsuHb",
"user": {
"login": "deepampriyadarshi",
"id": 65447610,
"node_id": "MDQ6VXNlcjY1NDQ3NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/65447610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/deepampriyadarshi",
"html_url": "https://github.com/deepampriyadarshi",
"followers_url": "https://api.github.com/users/deepampriyadarshi/followers",
"following_url": "https://api.github.com/users/deepampriyadarshi/following{/other_user}",
"gists_url": "https://api.github.com/users/deepampriyadarshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/deepampriyadarshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deepampriyadarshi/subscriptions",
"organizations_url": "https://api.github.com/users/deepampriyadarshi/orgs",
"repos_url": "https://api.github.com/users/deepampriyadarshi/repos",
"events_url": "https://api.github.com/users/deepampriyadarshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/deepampriyadarshi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-07T15:57:35Z",
"updated_at": "2023-02-07T15:57:35Z",
"author_association": "NONE",
"body": "Hi @laurent22 can I get a review on my latest commit [66e8804](https://github.com/laurent22/joplin/pull/7708/commits/66e8804c6606c8f9fa1978a2dd992c9ec32fc405). I believe that this will solve the above mentioned issues.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1421009371/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1426719360",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1426719360",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1426719360,
"node_id": "IC_kwDOBLftOs5VCgKA",
"user": {
"login": "deepampriyadarshi",
"id": 65447610,
"node_id": "MDQ6VXNlcjY1NDQ3NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/65447610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/deepampriyadarshi",
"html_url": "https://github.com/deepampriyadarshi",
"followers_url": "https://api.github.com/users/deepampriyadarshi/followers",
"following_url": "https://api.github.com/users/deepampriyadarshi/following{/other_user}",
"gists_url": "https://api.github.com/users/deepampriyadarshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/deepampriyadarshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deepampriyadarshi/subscriptions",
"organizations_url": "https://api.github.com/users/deepampriyadarshi/orgs",
"repos_url": "https://api.github.com/users/deepampriyadarshi/repos",
"events_url": "https://api.github.com/users/deepampriyadarshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/deepampriyadarshi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-11T12:01:57Z",
"updated_at": "2023-02-11T12:01:57Z",
"author_association": "NONE",
"body": "Hi @laurent22 my recent commit [a351969](https://github.com/laurent22/joplin/pull/7708/commits/a351969a6f0aac0fa598c9a71463e6f95afd6e30) has all the necessary refactoring that you asked. If you feel it's okay to merged then do notify me. I will squash up all the intermediate commits to clean up the commit tree.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1426719360/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1427123029",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1427123029",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1427123029,
"node_id": "IC_kwDOBLftOs5VECtV",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-12T20:17:42Z",
"updated_at": "2023-02-12T20:17:42Z",
"author_association": "OWNER",
"body": "Thanks for the detailed @deepampriyadarshi, I appreciate although that might take me a while to review this!",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1427123029/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445123044",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1445123044",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1445123044,
"node_id": "IC_kwDOBLftOs5WItPk",
"user": {
"login": "deepampriyadarshi",
"id": 65447610,
"node_id": "MDQ6VXNlcjY1NDQ3NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/65447610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/deepampriyadarshi",
"html_url": "https://github.com/deepampriyadarshi",
"followers_url": "https://api.github.com/users/deepampriyadarshi/followers",
"following_url": "https://api.github.com/users/deepampriyadarshi/following{/other_user}",
"gists_url": "https://api.github.com/users/deepampriyadarshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/deepampriyadarshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deepampriyadarshi/subscriptions",
"organizations_url": "https://api.github.com/users/deepampriyadarshi/orgs",
"repos_url": "https://api.github.com/users/deepampriyadarshi/repos",
"events_url": "https://api.github.com/users/deepampriyadarshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/deepampriyadarshi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-25T13:42:18Z",
"updated_at": "2023-02-25T13:42:18Z",
"author_association": "NONE",
"body": "Hi @laurent22 can this PR be merged?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445123044/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445384479",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1445384479",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1445384479,
"node_id": "IC_kwDOBLftOs5WJtEf",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-26T15:06:42Z",
"updated_at": "2023-02-26T15:06:42Z",
"author_association": "OWNER",
"body": "I've recently implemented this to fix an issue when the theme is automatically switched between dark and light: d1e545ac2c3b79d2c76a102bdc3046799607a716 And as far as I can see it also fixed the issue in this PR, isn't it?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445384479/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445409920",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1445409920",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1445409920,
"node_id": "IC_kwDOBLftOs5WJzSA",
"user": {
"login": "deepampriyadarshi",
"id": 65447610,
"node_id": "MDQ6VXNlcjY1NDQ3NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/65447610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/deepampriyadarshi",
"html_url": "https://github.com/deepampriyadarshi",
"followers_url": "https://api.github.com/users/deepampriyadarshi/followers",
"following_url": "https://api.github.com/users/deepampriyadarshi/following{/other_user}",
"gists_url": "https://api.github.com/users/deepampriyadarshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/deepampriyadarshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deepampriyadarshi/subscriptions",
"organizations_url": "https://api.github.com/users/deepampriyadarshi/orgs",
"repos_url": "https://api.github.com/users/deepampriyadarshi/repos",
"events_url": "https://api.github.com/users/deepampriyadarshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/deepampriyadarshi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-26T17:03:22Z",
"updated_at": "2023-02-26T17:03:22Z",
"author_association": "NONE",
"body": "Yes except the cache inconsistency one...\r\nSo i will close this PR now.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445409920/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445421612",
"html_url": "https://github.com/laurent22/joplin/pull/7708#issuecomment-1445421612",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7708",
"id": 1445421612,
"node_id": "IC_kwDOBLftOs5WJ2Is",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-26T18:02:32Z",
"updated_at": "2023-02-26T18:02:32Z",
"author_association": "OWNER",
"body": "Actually the cache consistency one is a good fix, any chance you could add just this to a PR? (I'd re-open this one but looks like the source branch is deleted)",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445421612/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接