wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/imshubham22apr-gif_232333933.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

616 行
45 KiB
JSON
原始文件 永久链接 Blame 文件历史

此文件含有不可见的 Unicode 字符

此文件含有人类无法区分的不可见的 Unicode 字符，但可以由计算机进行不同的处理。 如果您是想特意这样的，可以安全地忽略该警告。 使用 Escape 按钮显示他们。

此文件含有可能会与其他字符混淆的 Unicode 字符。 如果您是想特意这样的，可以安全地忽略该警告。 使用 Escape 按钮显示他们。

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14475",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14475/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14475/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/14475/events",
"html_url": "https://github.com/laurent22/joplin/pull/14475",
"id": 3993560437,
"node_id": "PR_kwDOBLftOs7GcJ1k",
"number": 14475,
"title": " Desktop: Fixes #14468: Note not moving from panel when clicked",
"user": {
"login": "imshubham22apr-gif",
"id": 232333933,
"node_id": "U_kgDODdkibQ",
"avatar_url": "https://avatars.githubusercontent.com/u/232333933?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/imshubham22apr-gif",
"html_url": "https://github.com/imshubham22apr-gif",
"followers_url": "https://api.github.com/users/imshubham22apr-gif/followers",
"following_url": "https://api.github.com/users/imshubham22apr-gif/following{/other_user}",
"gists_url": "https://api.github.com/users/imshubham22apr-gif/gists{/gist_id}",
"starred_url": "https://api.github.com/users/imshubham22apr-gif/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/imshubham22apr-gif/subscriptions",
"organizations_url": "https://api.github.com/users/imshubham22apr-gif/orgs",
"repos_url": "https://api.github.com/users/imshubham22apr-gif/repos",
"events_url": "https://api.github.com/users/imshubham22apr-gif/events{/privacy}",
"received_events_url": "https://api.github.com/users/imshubham22apr-gif/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [
{
"id": 519700741,
"node_id": "MDU6TGFiZWw1MTk3MDA3NDE=",
"url": "https://api.github.com/repos/laurent22/joplin/labels/bug",
"name": "bug",
"color": "cf353b",
"default": true,
"description": "It's a bug"
},
{
"id": 1080341216,
"node_id": "MDU6TGFiZWwxMDgwMzQxMjE2",
"url": "https://api.github.com/repos/laurent22/joplin/labels/desktop",
"name": "desktop",
"color": "ffc274",
"default": false,
"description": "All desktop platforms"
}
],
"state": "closed",
"locked": false,
"assignees": [],
"milestone": null,
"comments": 8,
"created_at": "2026-02-26T06:27:12Z",
"updated_at": "2026-03-05T08:59:13Z",
"closed_at": "2026-03-05T08:38:14Z",
"assignee": null,
"author_association": "NONE",
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/14475",
"html_url": "https://github.com/laurent22/joplin/pull/14475",
"diff_url": "https://github.com/laurent22/joplin/pull/14475.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/14475.patch",
"merged_at": null
},
"body": "Fixes #14468\r\n\r\n## Problem\r\nWhen a note is opened in a new window and the user switches focus between windows, clicking a note in the main window's note list doesn't update the editor panel.\r\n\r\nThis happens because `NoteList2`'s [mapStateToProps](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/app-desktop/gui/NoteList/NoteList2.tsx:328:0-355:2) reads `notesParentType`, `highlightedWords`, and `parentFolderIsReadOnly` from the top-level state instead of per-window state. When `WINDOW_FOCUS` fires, the reducer's [handleFocus](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:959:1-978:3) swaps the WindowState properties — it copies the secondary window's properties into the top-level [state](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:455:0-460:1) and moves the main window's properties into `backgroundWindows`. So each NoteList2 instance ends up reading the wrong window's values, causing incorrect `parentFolderIsReadOnly` computation (which can block drag-and-drop and note interactions) and wrong `notesParentType` (which breaks `useMoveNote` behavior).\r\n\r\n## Solution\r\nRead `notesParentType`, `highlightedWords`, and `parentFolderIsReadOnly` from [windowState](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:415:1-423:2) (via `stateUtils.windowStateById()`) instead of the top-level [state](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:455:0-460:1). [windowStateById](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:415:1-423:2) returns [state](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:455:0-460:1) itself if it's the focused window, or `state.backgroundWindows[windowId]` otherwise — so each NoteList2 always reads its own window's state regardless of which window is currently focused. This is consistent with how `NoteEditor` already handles multi-window state.\r\n\r\nLow-risk change — only affects [mapStateToProps](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/app-desktop/gui/NoteList/NoteList2.tsx:328:0-355:2) in [NoteList2.tsx](cci:7://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/app-desktop/gui/NoteList/NoteList2.tsx:0:0-0:0).\r\n\r\n## Test Plan\r\n- Added a reducer test verifying that [windowStateById](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:415:1-423:2) returns correct per-window `notesParentType` and `selectedFolderId` after `WINDOW_FOCUS` swaps.\r\n- Manual: Open a note in a new window → switch focus between windows → verify note selection works correctly in the main window's note list.\r\n",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14475/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14475/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3964393399",
"html_url": "https://github.com/laurent22/joplin/pull/14475#issuecomment-3964393399",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14475",
"id": 3964393399,
"node_id": "IC_kwDOBLftOs7sS9e3",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-26T06:27:26Z",
"updated_at": "2026-03-05T08:59:13Z",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3964393399/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2026-05-05T14:51:38Z",
"permissions": {
"actions": "write",
"administration": "read",
"artifact_metadata": "write",
"attestations": "write",
"checks": "write",
"code_quality": "write",
"contents": "write",
"copilot_requests": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3964404713",
"html_url": "https://github.com/laurent22/joplin/pull/14475#issuecomment-3964404713",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14475",
"id": 3964404713,
"node_id": "IC_kwDOBLftOs7sTAPp",
"user": {
"login": "coderabbitai[bot]",
"id": 136622811,
"node_id": "BOT_kgDOCCSy2w",
"avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coderabbitai%5Bbot%5D",
"html_url": "https://github.com/apps/coderabbitai",
"followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-26T06:29:28Z",
"updated_at": "2026-03-02T05:45:05Z",
"body": "<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\nNo actionable comments were generated in the recent review. 🎉\n\n<details>\n<summary>ℹ️ Recent review info</summary>\n\n**Configuration used**: Path: .coderabbit.yaml\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n<details>\n<summary>📥 Commits</summary>\n\nReviewing files that changed from the base of the PR and between a9ac65d5652bf2aac833a118db5e6b1ecf2e5609 and 84de4aa389a6e0721784a915830294537a37b1f5.\n\n</details>\n\n<details>\n<summary>📒 Files selected for processing (1)</summary>\n\n* `packages/lib/reducer.test.ts`\n\n</details>\n\n</details>\n\n---\n\n\n<!-- walkthrough_start -->\n\n<details>\n<summary>📝 Walkthrough</summary>\n\n## Walkthrough\n\nmapStateToProps in NoteList2 now sources folder/note context (selectedFolder, notesParentType, highlightedWords) from window-scoped state; reducer exports a new stateUtils and tests were added to verify per-window state behavior across WINDOW_FOCUS swaps.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**NoteList state mapping** <br> `packages/app-desktop/gui/NoteList/NoteList2.tsx`|mapStateToProps now derives `selectedFolder`, `notesParentType`, `selectedFolderId`, `highlightedWords`, and read-only determination from `windowState` instead of top-level state. Removed previous top-level state selections.|\n|**Reducer exports & tests** <br> `packages/lib/reducer.ts`, `packages/lib/reducer.test.ts`|Added and re-exported `stateUtils` from the reducer module; introduced tests validating per-window state via `windowStateById` across `WINDOW_OPEN`/`WINDOW_FOCUS` swaps.|\n\n## Suggested labels\n\n`desktop`, `bug`\n\n</details>\n\n<!-- walkthrough_end -->\n\n\n<!-- pre_merge_checks_walkthrough_start -->\n\n---\n\n<!-- pre_merge_checks_override_start -->\n> [!IMPORTANT]\n> ## Pre-merge checks failed\n> \n> Please resolve all errors before merging. Addressing warnings is optional.\n<!-- pre_merge_checks_override_end -->\n\n### ❌ Failed checks (1 error)\n\n| Check name | Status | Explanation | Resolution |\n| :-----------------------------------: | :------ | :------------------------------------------------------------------------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Pr Description Must Follow Guidelines | ❌ Error | PR description lacks explicit Test Plan or verification steps section required by custom check guidelines, despite tests being added to reducer.test.ts. | Add dedicated Test Plan section documenting new test for per-window state isolation, test scenarios covered (WINDOW_OPEN, WINDOW_FOCUS transitions), and manual verification steps. |\n\n<details>\n<summary>✅ Passed checks (5 passed)</summary>\n\n| Check name | Status | Explanation |\n| :------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |\n| Title check | ✅ Passed | The title accurately references the specific issue (`#14468`) and describes the main fix: ensuring notes move/appear in the panel when clicked. |\n| Description check | ✅ Passed | The description is directly related to the changeset, explaining the root cause (reading from wrong state) and the fix (reading from windowState). |\n| Linked Issues check | ✅ Passed | The changes address the core requirement from `#14468`: fixing note selection in the editor panel by ensuring per-window state isolation via windowState instead of global state. |\n| Out of Scope Changes check | ✅ Passed | The changes are within scope: NoteList2.tsx mapStateToProps modifications and reducer test additions directly support fixing `#14468`'s note-switching issue. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n</details>\n\n<!-- pre_merge_checks_walkthrough_end -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing Touches</summary>\n\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} --> Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"07f1e7d6-8a8e-4e23-9900-8731c2c87f58\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} --> Post copyable unit tests in a comment\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14475)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n\n<!-- internal state start -->\n\n\n<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKPR1AGxJcAItIDWBNxcAGLwAB7SkGYAjAAscQBsABxcAHL4NJAYmZDM+BLwGESQAGYULDyYJB6QAO6wZIwe8Az+dJAAFLbR8XEA7ACsAJSQkAYAgniw+BRc8MyIsNgCsGjMAEwbaLzE8KVjBtDOpLiQAlQYDLBcShKHAMq41NiIXPjcZEZ+iAwU8NxxPgMBwDFAAJJYDI0AAySFwGw0zB2T2oJGg+CsFW4yEQJCkVFqvA+lHEUU6ORoiCsznY0FknwANJAEERYC02TRaAB1Wa0RDMvFeMR0EL4DxKCjg2jM7i0jC4MUSyjgxA2EhoWgAeQwHlkozqlBIkAoGvo5UquEakCCYC8UlqRA8gjQtUQzyyRXdZv4BytxrqRVo+DqYEQnwY+1a9SDIdRNA0YMg3MaWGY2A84m4XhjGGDdWQtMgrzozO54LSPi13IA+iEtQBhACqD3sdR2yEDeZD9g90gA3CazUUSlb8HieNjSfAohbmJAnS63X2FBn6KbcNgKFgJK7sFEBDVgUQRzb8OhILR9qUjQrc/nmQw0K9T9CSHD3WeWWgpDbrXUKmKBQFRIcIzk6ADjzKcVJQAejlU071wBkSGGRMoDgag8iQZFcGuVcJUnfF2D/Y1KWNFpPznYtuFoahT39SA6HUWYqnIWpgXsEcvDABgWjaLpGOYgg+FNZEig6d1sDaYZmQaeAc2DFYeL41p/H4T5yHoRjyJQLA0GyEg6nvEN0Jga1rkwUgh01ZByOpeVcHpJkWXgNkOVgLleQoflmUwdcajRehiRxMoKnnLt83jY1CgM900SbcQPEQDRIrjPsACFZGlTpZPQDkMFfTJ33hDYYytFkezfABRK8RO/PMvE7WNQ1+El6HirJ/KHd1ZlPJgKFNMQeEoMA0uMw81kKWZEwMCxIC1YRRHEKRkGoloMHaegkAcaQjCgdVetNJjwgjLlzhIKb4FY6idv3XoEhSLgGiaAySz4RBuJIXj+P8QtsmKm1PGNIpSIBrJKNwZkrSw3SlnwNd0G4T5nD0sHxKwXThNPOV2K6Skhwx3tpPUziDN4fFrtecHULM6qMAcY7PgoMaWt7NEUEQcV6M4rmabteFgJoMCulKGDKFlRybRQ5lTU1MBgT1dnNwFVz3LczyOjqPlVZIPCNFGU1SmFXBkEYtAxEkAMWsATAJcRXbrgyiAnTmA0oS3oNBShoPhy0ras60bFs2w7MywnCMHuRaxAwFNbhZnOgRsBKF7jsV+QlIEFTfo0sgzetJRPtNehdM6UGDPIYzxoNBAc0+4ps7UsptGSr9sFojmhLq1jcZIWb5obFg2AVXFHGRFx9pQRZllWdYth2FmTwOJgMFKeAKDYDq3MKoDGIbGEJjM5muYwV14AALzoI3/lIKh6tNQojI6RjLOKY1uqDVogpQM5nXwP6FCDWWoOU0ABHfc3pPZ5FmCDDAYAlCAlgCdbMmAeZYHwAcGYxkigDSGmcXcHgIHQT4PZGkiEnIoXQHmKo5ClSSlVOqTUOolYXA1OpOGgY8IIGKBocyJB5BoEQFtZ6qY2zqGuKeAQFt1IEHRtoLA41BQzDXBgAA5GcMcE4CFEPbnRLIsjcL4R0oDSGAB+SAkJ6gIHwk+PEyBgykXkGJeRelcHLXsOeWIj1kj8AYAwLciBTFJmPsCM+l9aDXzcsoeqro+bkXoAAcQePgBssdArnVsLiZRhExYeGdMZJJKSeAZlqGAiBZwiDYHgEoDaUR9hI2zF/LOfckweGfOQrY6AhHP2tM+McfBZErzXhvRx6A07qU4UgpgzBsx6wYtaWw/dLCD1YOoPI0hEBoFIKPJwE8kwTBtNIM47ZCy0CULQLgAAiCYZzDlUR7qNcaysQZczaUCfS3tKDJgrFWWs9ZmytkQO2bglzICABQCPSV4nxUgvNgQquBYJFBoEQO+10sBUmOYIvSuAKi0Gks/c8BJ9jyHGmGJgnwOormcV6Tm3NzrdTccNL2Ptvn+z+UHQFwKUr7TAIYAwJgoBkHoBgnABBiBkGiR0aZw9OCTn4EtS2q1zjyCYJKFQahNDaF0Ly/l4AMIIGQKgTAorCCkHIHfKVQ92BcCoMZBwuz5ByAUGq1Q6gtA6H0EYXVpgDByjaFs6QsEdjcHgQEIIsFKnwFgm+D8CKY2lQ0KbcIoJLmprmpYCY4JxXmu/va8e8gRWv22UYZE3BooYixB8OyPZJRW2QPkY62jZzhRMnUaKelvSal9GeEN9oajPK4EKZaopxYUGZKQxyzkSB+WoaydkGsvI62LBOca0UNATvIVOyAsFW1rqHSKWgdCVT0B3auvsGg50eUXT5ZAppwzLStnqQcjEKbTWpp1b6Ui8QdRqA+4EhZjpiQKHQXhcBjS1qkD+k2I7lRSk9tQ00byOjGy2cgTo+6uRHqlBgaAVAlijBXuIDA91ZGHmQeOUs5w8BDiVpxRiujv5no5lzLcDA+40PYFhhhZpmHyGdCeBgnMaJ6IJUOG8iE2O7vPRuuklCvQ0C7SKj967ioOU3ZQl6WAlA+2YEUU8ctaAK11PITqrxeFagJK6Dw0NrTuyuO8gGxkSzNW7K1clkkVxiz4LkuCulCOgShugUoN5LZARkwqKdgpf0Hq4zKew0XMOjuZJehddBvK+SoQFeW6dLx60oLp0+7y5K12NO9aUmX4uWY4v6bzM4JS3pIETFjFA2PmhbS+h+VNkDOmhWilKkAMiMDWG/L8dnLa823i8O9/A+CgXjhQM4k0fzXQoLNcwGbMzRL61+RiSg+LODQcgEVc2E4dB7spaM7B1AzkQJPQbrofaHa/HttpqL/3dpOwts7fBuAXcE1dsk9i8sHtmnCcgyAi10C4AAakGLBMAgwjDVXdAsb+qrjSdaMkxYLCcuAAFlmKOAMKmy5PKwBGD9f4ANiBYItAELBYu+LVsYsTW8Ynab5qZuzZKjqY9nAFuXsN4tSZqqnVO8FP7TEFTqFkIOvsiUFKdixZqc5O3rSM7Y3wfIeKczdVNGAT750vMnR9qfWoJYzLQCORdK6swuAHMrncjRwN6CXPhojYkhQlCALwSNFmTyP2QFilJtEWVyvMq+X7X5gcAUhxBfULFSLcX4u0oSygxK/es1c88n3y1weFj+OOZAUeA7/ODkCjszIXxATiqIYEdEXCtvKkg9QR26iY1UxVnzlB+tgadydSgkY7Gsuj1qKw1U0hlh+aXjlM76Al/ZbHqRbQ/KIDxAt08pL72RjXoJwPweP0K+SqlFq0Uw/0EPF59+1CI8fS5aB60GKGkagoGbc8ZGVcdFBrgbWPA2lsdVk/l6yAjxUaV604m/wLmvDW3TUgAmE2zewZjV3A1EFeye2OzFy+2FR+0lwBxu0nlF3mzOE/wuWeSP0NTTEUAzGNA0AZzoCZy6Ep2p1p3gHpw10oFZ2GCMDByiEh1IOhziDhzABiCRxR1wktW90x2MhIBxwWy4AAAkNZ2dScwQdVvVBVqERU+lTUJULV6BpVrUTQ0A7U+dG8nV0cqBXVNUPUdUBUFBVlcAaxqlEAawpC6Aax4oFttU+U7C0AABOC2RIQYWgQYIIjYAQUobYC2ZIAAZhiLQBiBiGSFoAEEGBIESAEBiFEEiJIFCIAAY/DvD1DIBkg4glA4g0A0AYjkgAjEgSA8j+gNgYh+hSj/CYhBhYi8iNg/DBCYj+gqj+hMjShBgijijpV1AnD+RXDKYn5aAawhUii7CKYaw2AKBSAaxrhRA/oPDngvDPUDAABvAwMYS5JAWwDKHrLaFZGVKwccLkS5LgUoWJadY4yAN3bJWgC4/ANoWwB45uZKF4k4pACzSgf4M5MgP4p4gExkV4y5K8WgGwOFHwb4p4f4YoRABsRoNoP4nFfcGEk4+ExEnDYGTErYnEigPE2EwkpE6QP4AEd5Uk7ErgXEwEt4jaLaVUXaRAVEv4y5AAHQwAFL5NwGFNFJFPFOAHZPcLuhID0CFPFLFLFIsEsC8SSFSAG0BgJnyEKCAmol7g8CFMFIVONOFPmncFwC8ENLfHBmgR1JKD1OqANMFIwHmh+DpMBDRUNOVIWmZnoiAkQFkG9GYENKjlc0QC9PmgACkPgNog8e9PTnSYiNBBgNAYgNgIzLAfhAgPg4zX80U9IxZDSkyUy0yMzIAGwtxyEbdlsEYKBDSDkMMOhdJxALTrY8kbS45/9jQhJwh4RTxgRYEwZsYgJ9SH9jQct2x5BZFXZZFdtpB14mzAZUBM4cxVIBJGIWycx5J8JAx2ySR0VrRdJy5DIq4WpeE+ETo+ywslyDzjR9T4tGt7YSZeFoRuEU4FJahIcf5IAyzCDh0L9LoaytwQzREK5AZNyXlmg1IelYZAY1hCwPBJzCxkYX8v9byaYmI6ocZHSfznTvSYR8AiBwznTXz+ohc6l0KUMiLE0RZNMLFmgKNmR9yKs1zSYO99FgZkBwQE8kJzx9zn1rQByMLUAUd2ypIBJIDjRhyShe55TFTjTgAWDNppS199w9BLl8S2TBFcBGT/BDoMxTY/iABtV4sYI4sYCyt4zYtoNIdYEgXk801crE/wDS0yiyt3D0V4ckykyyk4ubNpQrNFByx/YGdAPxLcNEJWI2W8AAsGbfKMQTGUroVUlIUYR2Wk/4Q8fOY0ImNeZNKXRmU8eyW0kgINFC1GSStiftOi1ikDVy3yt47Xeyq5dsbcEceq3yy5IaYENeSpU0SE54zSyyy5PqE8M3XS2ytgXkiC0nSygAXyGsgHMs6usv8EmuareLdP+A9M4lWo6uGtM0QG8tZOGv8tQXeWCpQN+G2oc2XIXLECivSVExfnIrxECzOr013nV3wFyCfBLC6AM1PGokgn9L7DSuoUYjyoBuHF1JbSYxoDQn2vcqat5Nap3iICRpOO6tXjci3A2qhLxEWpONGqKFdAmrst5MLndIurcoWrcuWuGtWvWt5LBy2gsVUt4OcsxreMOuOqJreLOsCuBEuqGysiiBVzvWysAQxxIHAQXJlTCkqBSvVLyqKsBgw3zMquEh7hwqdTzi3BxkeTZkDyQDpXzOD3htgU7WFQOEXCkWXDRA0G5suRRpaucHRuduxt6rxoGuhLcuJpvlJo8HJqmquSlNoE5IgQmDXw2RlVmosrpssoZvcqZopquS1GoxFQeHc3LNeqGzJP5o8peCOuZIpJOvcsFrQRFshwA2titFBjak+HSGKljURCTTyBRD7ArWxHrUUASqez13oM137xV2u3eyvDwSVgcGRgTjKAiFPGVtUWrRoDDE4QkSAhlKdsLtdreLRvasLq9txv6seMGv9reJJvGucuZquQRlwC1FKGzpJExLFsQGjrsUQDjtpsWuTpONTtDs2u+PdDRJKEHks1IGdt5tLp8s6srouquUGzG3eTWgRmoUqr4Lnqai/HxD3A5mDAYCAf6mAyoFIF4QeH8ABG4FPDwYIaAiYDAeNFWq3rPq6ukHFDwCCquW5H+CyGoZxRHGQYGVszhXGyQN0zX3mUay/E2XEEQFKCnIsiIYDT/DvRmAlCYYapdsUA2suT3uKGdovrJqvrTreN4eAaOq/vpuYdgY4beJ6CppuvzP/wAX8taDWSt0/CsACpm1zP7oc29FCjxBEaHDluLmVUYFeAIHnFWoXCqRqQklVkLkof0SORkBIFPBIK/HYOZyOVZ3Uc6rvTYbgbeJuXoHOS/nOncbOE8eNUCYczwccCuzCyxyf2N2Ziz3zBz1NreTRWhmt1+DIGcGughyIY6E6AXxrDHwnynzZRj2DhxUwE+iQbym6mRGI1dB8d3zQV7BIBxDycZqMf/suSxEgC2vpPzLxwicgCVHyUgASViZqHiedp3suVBNmAgc8pLv+MJuYcPr6vxtPo0YMeDoOe0f8V6mYHjrGDmteIAF1NLLk2l3RbBTmdqMBeSKjYiYgYjaBkh+g/Fkj+gSB+hShEg0AWjGjkgYgSXaA4gYiYg/Dkg8ikjuiBgZC0A4hSh+g6iGBaANhBgYjSgEgSAGXEhaAuXBgOqEXtLbBHLtGQiNgBXaAkiZCuWBANgMiGBiWBACinivY4gNhShMjBhBg8j/CGiIini6iSBKW0jTW/CBBCWFWHW/ClWKjJXTGRxQHlBSBIRTdXRoo/iDjoXoXijljVj1jVqXCFjPVfC8B8Aaw5QSwdi0Rk29i1CDipWkXnxv0JhcB1RH5DRaBrj1BB44VcAHi8iQ3Y2CAE3s2SBk2aB5jqF9AgA=== -->\n\n<!-- internal state end -->",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3964404713/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 347564,
"client_id": "Iv1.6aaafe4fe882736b",
"slug": "coderabbitai",
"node_id": "A_kwHOB96YWc4ABU2s",
"owner": {
"login": "coderabbitai",
"id": 132028505,
"node_id": "O_kgDOB96YWQ",
"avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coderabbitai",
"html_url": "https://github.com/coderabbitai",
"followers_url": "https://api.github.com/users/coderabbitai/followers",
"following_url": "https://api.github.com/users/coderabbitai/following{/other_user}",
"gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions",
"organizations_url": "https://api.github.com/users/coderabbitai/orgs",
"repos_url": "https://api.github.com/users/coderabbitai/repos",
"events_url": "https://api.github.com/users/coderabbitai/events{/privacy}",
"received_events_url": "https://api.github.com/users/coderabbitai/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "coderabbitai",
"description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n",
"external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github",
"html_url": "https://github.com/apps/coderabbitai",
"created_at": "2023-06-14T15:47:27Z",
"updated_at": "2026-03-14T07:58:44Z",
"permissions": {
"actions": "read",
"checks": "write",
"contents": "write",
"discussions": "read",
"issues": "write",
"members": "read",
"metadata": "read",
"pull_requests": "write",
"statuses": "write"
},
"events": [
"issues",
"issue_comment",
"label",
"organization",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"pull_request_review_thread",
"release",
"repository"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3964584461",
"html_url": "https://github.com/laurent22/joplin/pull/14475#issuecomment-3964584461",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14475",
"id": 3964584461,
"node_id": "IC_kwDOBLftOs7sTsIN",
"user": {
"login": "imshubham22apr-gif",
"id": 232333933,
"node_id": "U_kgDODdkibQ",
"avatar_url": "https://avatars.githubusercontent.com/u/232333933?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/imshubham22apr-gif",
"html_url": "https://github.com/imshubham22apr-gif",
"followers_url": "https://api.github.com/users/imshubham22apr-gif/followers",
"following_url": "https://api.github.com/users/imshubham22apr-gif/following{/other_user}",
"gists_url": "https://api.github.com/users/imshubham22apr-gif/gists{/gist_id}",
"starred_url": "https://api.github.com/users/imshubham22apr-gif/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/imshubham22apr-gif/subscriptions",
"organizations_url": "https://api.github.com/users/imshubham22apr-gif/orgs",
"repos_url": "https://api.github.com/users/imshubham22apr-gif/repos",
"events_url": "https://api.github.com/users/imshubham22apr-gif/events{/privacy}",
"received_events_url": "https://api.github.com/users/imshubham22apr-gif/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-26T07:14:41Z",
"updated_at": "2026-02-26T07:14:41Z",
"body": "I have read the CLA Document and I hereby sign the CLA",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3964584461/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3967016296",
"html_url": "https://github.com/laurent22/joplin/pull/14475#issuecomment-3967016296",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14475",
"id": 3967016296,
"node_id": "IC_kwDOBLftOs7sc91o",
"user": {
"login": "personalizedrefrigerator",
"id": 46334387,
"node_id": "MDQ6VXNlcjQ2MzM0Mzg3",
"avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/personalizedrefrigerator",
"html_url": "https://github.com/personalizedrefrigerator",
"followers_url": "https://api.github.com/users/personalizedrefrigerator/followers",
"following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}",
"gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}",
"starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions",
"organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs",
"repos_url": "https://api.github.com/users/personalizedrefrigerator/repos",
"events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}",
"received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-26T14:32:04Z",
"updated_at": "2026-02-26T18:22:23Z",
"body": "Thank you for the pull request! For correctness, this change looks good to me.\r\n\r\n> This is a problem because when you open a note in a new window and switch focus, WINDOW_FOCUS swaps the window states around — so state.notesParentType ends up pointing to the wrong window's value.\r\n\r\nA more in-depth explanation for how this fixes #14468 would be appreciated! How do incorrect values for `notesParentType` and `parentFolderIsReadOnly` break switching notes? When the user switches back to the main window, `notesParentType`, `parentFolderIsReadOnly`, etc. should update to match the note list's content. In what cases are `notesParentType` and `parentFolderIsReadOnly` still incorrect such that #14468 can happen?\r\n\r\n(**Edit**: If this pull request is related to GSoC, please also [follow the GSoC pull request guidelines](https://github.com/joplin/gsoc/blob/master/pull_request_guidelines.md)).",
"author_association": "COLLABORATOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3967016296/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3979844258",
"html_url": "https://github.com/laurent22/joplin/pull/14475#issuecomment-3979844258",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14475",
"id": 3979844258,
"node_id": "IC_kwDOBLftOs7tN5qi",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-01T12:10:16Z",
"updated_at": "2026-03-01T12:10:16Z",
"body": "@imshubham22apr-gif, please confirm you are ok with completing this PR",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3979844258/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3982285008",
"html_url": "https://github.com/laurent22/joplin/pull/14475#issuecomment-3982285008",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14475",
"id": 3982285008,
"node_id": "IC_kwDOBLftOs7tXNjQ",
"user": {
"login": "imshubham22apr-gif",
"id": 232333933,
"node_id": "U_kgDODdkibQ",
"avatar_url": "https://avatars.githubusercontent.com/u/232333933?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/imshubham22apr-gif",
"html_url": "https://github.com/imshubham22apr-gif",
"followers_url": "https://api.github.com/users/imshubham22apr-gif/followers",
"following_url": "https://api.github.com/users/imshubham22apr-gif/following{/other_user}",
"gists_url": "https://api.github.com/users/imshubham22apr-gif/gists{/gist_id}",
"starred_url": "https://api.github.com/users/imshubham22apr-gif/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/imshubham22apr-gif/subscriptions",
"organizations_url": "https://api.github.com/users/imshubham22apr-gif/orgs",
"repos_url": "https://api.github.com/users/imshubham22apr-gif/repos",
"events_url": "https://api.github.com/users/imshubham22apr-gif/events{/privacy}",
"received_events_url": "https://api.github.com/users/imshubham22apr-gif/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-02T05:51:22Z",
"updated_at": "2026-03-02T05:51:22Z",
"body": "@laurent22 Yes, I'm completing this PR. I've added a test unit and updated the description with a detailed explanation.\r\n\r\n@personalizedrefrigerator Thanks for the review! Here's a more in-depth explanation:\r\n\r\n**How `WINDOW_FOCUS` breaks things:** When a secondary window gains focus, the reducer's [handleFocus](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:959:1-978:3) (reducer.ts ~line 960) **swaps** the WindowState properties — it copies the secondary window's properties into the top-level [state](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:455:0-460:1) and moves the main window's properties into `backgroundWindows`.\r\n\r\n**The bug:** Before this fix, `NoteList2`'s [mapStateToProps](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/app-desktop/gui/NoteList/NoteList2.tsx:328:0-355:2) was reading `notesParentType`, `highlightedWords`, and `parentFolderIsReadOnly` directly from `state.*` (top-level). Since each window has its own `NoteList2` instance, when the secondary window gained focus, the main window's NoteList would re-render with the **secondary window's** `notesParentType` and `selectedFolderId`.\r\n\r\nThis causes `parentFolderIsReadOnly` to be computed from the wrong folder (the secondary window's folder instead of the main window's). If this evaluates to `true` incorrectly, the drag-and-drop handler (`useDragAndDrop`) blocks interactions. Similarly, the wrong `notesParentType` can cause `useMoveNote` to behave incorrectly.\r\n\r\n**Why [windowStateById](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:415:1-423:2) fixes it:** `stateUtils.windowStateById(state, windowId)` returns [state](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:455:0-460:1) itself if it's the focused window, or `state.backgroundWindows[windowId]` otherwise. So each NoteList2 always reads its **own** window's state, regardless of which window is currently focused. This matches how `NoteEditor` already handles it.\r\n\r\nI've also added a test in the latest commit that verifies [windowStateById](cci:1://file:///c:/Users/dhara/Documents/Aashish/vscode/joplin/packages/lib/reducer.ts:415:1-423:2) returns correct per-window state after `WINDOW_FOCUS` swaps.\r\n",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3982285008/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3985650367",
"html_url": "https://github.com/laurent22/joplin/pull/14475#issuecomment-3985650367",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14475",
"id": 3985650367,
"node_id": "IC_kwDOBLftOs7tkDK_",
"user": {
"login": "personalizedrefrigerator",
"id": 46334387,
"node_id": "MDQ6VXNlcjQ2MzM0Mzg3",
"avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/personalizedrefrigerator",
"html_url": "https://github.com/personalizedrefrigerator",
"followers_url": "https://api.github.com/users/personalizedrefrigerator/followers",
"following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}",
"gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}",
"starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions",
"organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs",
"repos_url": "https://api.github.com/users/personalizedrefrigerator/repos",
"events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}",
"received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-02T17:04:32Z",
"updated_at": "2026-03-02T17:04:32Z",
"body": "Thank you for the additional explanation! I'm still not convinced that this change is related to https://github.com/laurent22/joplin/issues/14468.\r\n\r\n> This causes parentFolderIsReadOnly to be computed from the wrong folder (the secondary window's folder instead of the main window's). If this evaluates to true incorrectly, the drag-and-drop handler (useDragAndDrop) blocks interactions. Similarly, the wrong notesParentType can cause useMoveNote to behave incorrectly.\r\n\r\nLocally, even if I hardcode `parentFolderIsReadOnly` to `true`, I'm still able to switch between notes in the note viewer/editor pane (however drag-and-drop in the notes list doesn't work). As such, I don't think `parentFolderIsReadOnly` is related to https://github.com/laurent22/joplin/issues/14468.\r\n",
"author_association": "COLLABORATOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3985650367/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4003319494",
"html_url": "https://github.com/laurent22/joplin/pull/14475#issuecomment-4003319494",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14475",
"id": 4003319494,
"node_id": "IC_kwDOBLftOs7unc7G",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-05T08:38:14Z",
"updated_at": "2026-03-05T08:38:14Z",
"body": "Hello, since this pull request does not appear to be active, we are closing it to keep the PR backlog manageable. If you decide to continue working on it later, just let us know when it’s ready for review and we can reopen it.",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4003319494/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接