一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
864 行
37 KiB
JSON
864 行
37 KiB
JSON
{
|
|
"issue": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"repository_url": "https://api.github.com/repos/laurent22/joplin",
|
|
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7637/labels{/name}",
|
|
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7637/comments",
|
|
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/7637/events",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637",
|
|
"id": 1549915355,
|
|
"node_id": "PR_kwDOBLftOs5IKj8A",
|
|
"number": 7637,
|
|
"title": "Android: Resolves #6942: Improve safx performance",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"labels": [],
|
|
"state": "closed",
|
|
"locked": true,
|
|
"assignee": null,
|
|
"assignees": [],
|
|
"milestone": null,
|
|
"comments": 17,
|
|
"created_at": "2023-01-19T20:41:21Z",
|
|
"updated_at": "2023-01-21T14:11:57Z",
|
|
"closed_at": "2023-01-21T14:11:37Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"sub_issues_summary": {
|
|
"total": 0,
|
|
"completed": 0,
|
|
"percent_completed": 0
|
|
},
|
|
"active_lock_reason": null,
|
|
"draft": false,
|
|
"pull_request": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/pulls/7637",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637",
|
|
"diff_url": "https://github.com/laurent22/joplin/pull/7637.diff",
|
|
"patch_url": "https://github.com/laurent22/joplin/pull/7637.patch",
|
|
"merged_at": "2023-01-21T14:11:37Z"
|
|
},
|
|
"body": "Resolves #6942 (second task, hopefully)\r\nThis is _kinda_ done\r\nbecause it needs testing and review\r\nI have tested it locally (on emulator and debug build only)\r\n~~one Major issue I still did face was still UI was getting blocked\r\nI'm not sure if it's caused by my code or not (since I made everything async)~~\r\nsomeone I knew tried this with encrypted notes (~ 200 notes (2000 items, history ?), took ~ 11 minutes), and reported no UI freezes, so the freeze is probably a debug build thing\r\nI'd be happy if you review and make suggestions, I believe this can still be improved\r\n\r\nI did some quick test with new vs old performance, was improved by around 2x, but it depends on what is executed the most\r\nI tested this sequence 100 times, total time was reduced by around half (115660.735ms to 66570.203ms)\r\nSequence: mkdir, createFile, writeFile, writeFile(append), readFile, rename, copyFile, moveFile, unlink\r\n\r\nOne important note though: user's probably will have to repick their document if its not working after updating to this version",
|
|
"closed_by": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/7637/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7637/timeline",
|
|
"performed_via_github_app": null,
|
|
"state_reason": null
|
|
},
|
|
"comments": [
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1397575487",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1397575487",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1397575487,
|
|
"node_id": "IC_kwDOBLftOs5TTU8_",
|
|
"user": {
|
|
"login": "github-actions[bot]",
|
|
"id": 41898282,
|
|
"node_id": "MDM6Qm90NDE4OTgyODI=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
|
|
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
|
|
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
|
|
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
|
|
"type": "Bot",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-19T20:41:42Z",
|
|
"updated_at": "2023-01-21T05:46:59Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1397575487/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1397575758",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1397575758",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1397575758,
|
|
"node_id": "IC_kwDOBLftOs5TTVBO",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-19T20:42:01Z",
|
|
"updated_at": "2023-01-19T20:42:01Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "I have read the CLA Document and I hereby sign the CLA",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1397575758/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398176323",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398176323",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398176323,
|
|
"node_id": "IC_kwDOBLftOs5TVnpD",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T10:14:22Z",
|
|
"updated_at": "2023-01-20T10:14:22Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "I have some other ideas to improve, will change the state when It's done",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398176323/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398258052",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398258052",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398258052,
|
|
"node_id": "IC_kwDOBLftOs5TV7mE",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T11:35:13Z",
|
|
"updated_at": "2023-01-20T11:35:13Z",
|
|
"author_association": "OWNER",
|
|
"body": "(Moving the discussion here as it's easier)\r\n\r\nIf there are some changes, it is possible to add a migration step? Alternatively, can we somehow detect the condition when the app starts and prompt the user for permission or tell them what to do? If we simply document it in the changelog, half of users won't know about it, and we'll have too many support requests",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398258052/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398259440",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398259440",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398259440,
|
|
"node_id": "IC_kwDOBLftOs5TV77w",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T11:36:50Z",
|
|
"updated_at": "2023-01-20T12:09:26Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "I believe it's possible to have a migration step (without user interaction)",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398259440/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398630723",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398630723",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398630723,
|
|
"node_id": "IC_kwDOBLftOs5TXWlD",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T16:27:43Z",
|
|
"updated_at": "2023-01-20T16:27:43Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "I checked that if this needs a migration or not, and thankfully no it does not need, my other idea that I wanted to work on required though\r\n\r\nI kinda give up on the idea of improving it further, at least for now (proved to be harder than I thought)\r\nso lets merge this\r\nI'll make another PR in future if I work on it again",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398630723/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398636607",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398636607",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398636607,
|
|
"node_id": "IC_kwDOBLftOs5TXYA_",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T16:32:57Z",
|
|
"updated_at": "2023-01-20T16:32:57Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "fixing the lock file now",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398636607/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398690255",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398690255",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398690255,
|
|
"node_id": "IC_kwDOBLftOs5TXlHP",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T17:13:09Z",
|
|
"updated_at": "2023-01-20T17:13:09Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "Sorry @laurent22, I think I need your help on the rest, I tried to resolve it in the way I thought would be the right way",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398690255/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398728350",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398728350",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398728350,
|
|
"node_id": "IC_kwDOBLftOs5TXuae",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T17:39:09Z",
|
|
"updated_at": "2023-01-20T17:39:09Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "I just [found this](https://shipilev.net/blog/2014/exceptional-performance/), and skimmed through it, \r\nsince we didn't need stack trace from the java side of module, I removed the stack traces of Exceptions I made inside the module\r\n",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398728350/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398734345",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398734345",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398734345,
|
|
"node_id": "IC_kwDOBLftOs5TXv4J",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T17:44:34Z",
|
|
"updated_at": "2023-01-20T17:44:34Z",
|
|
"author_association": "OWNER",
|
|
"body": "> Sorry @laurent22, I think I need your help on the rest, I tried to resolve it in the way I thought would be the right way\r\n\r\nHelp with what?",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398734345/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398734992",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398734992",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398734992,
|
|
"node_id": "IC_kwDOBLftOs5TXwCQ",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T17:45:19Z",
|
|
"updated_at": "2023-01-20T17:45:19Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "with lock file conflict",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398734992/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398735902",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398735902",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398735902,
|
|
"node_id": "IC_kwDOBLftOs5TXwQe",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T17:46:20Z",
|
|
"updated_at": "2023-01-20T17:46:20Z",
|
|
"author_association": "OWNER",
|
|
"body": "That's easy - you just need to run \"yarn install\" and yarn will fix it for you",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398735902/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398736657",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398736657",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398736657,
|
|
"node_id": "IC_kwDOBLftOs5TXwcR",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T17:47:07Z",
|
|
"updated_at": "2023-01-20T17:47:33Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "well I have already done that, and it didn't help \r\n[fix: commit lock file from upstream](https://github.com/laurent22/joplin/pull/7637/commits/b1944678170979fe069e68473da01490492072d9)\r\n[fix: adjust deps of safx so we reuse version](https://github.com/laurent22/joplin/pull/7637/commits/6b248705977d141e65b7abfb36e4f3f86fc7b95f) \r\n[fix: remove node modules and re-run yarn install](https://github.com/laurent22/joplin/pull/7637/commits/976b2cd90eee45d3bfca5c08c48537711ffaa063)",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398736657/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398737757",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398737757",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398737757,
|
|
"node_id": "IC_kwDOBLftOs5TXwtd",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T17:48:19Z",
|
|
"updated_at": "2023-01-20T17:48:19Z",
|
|
"author_association": "OWNER",
|
|
"body": "I made changes a few minutes ago, so I think you just need to pull the latest changes and run yarn install again. If that doesn't work, please post the output of yarn install",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398737757/reactions",
|
|
"total_count": 1,
|
|
"+1": 1,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398738097",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398738097",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398738097,
|
|
"node_id": "IC_kwDOBLftOs5TXwyx",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T17:48:40Z",
|
|
"updated_at": "2023-01-20T17:48:40Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "okay",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398738097/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398845380",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1398845380",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1398845380,
|
|
"node_id": "IC_kwDOBLftOs5TYK_E",
|
|
"user": {
|
|
"login": "jd1378",
|
|
"id": 6196533,
|
|
"node_id": "MDQ6VXNlcjYxOTY1MzM=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6196533?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/jd1378",
|
|
"html_url": "https://github.com/jd1378",
|
|
"followers_url": "https://api.github.com/users/jd1378/followers",
|
|
"following_url": "https://api.github.com/users/jd1378/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/jd1378/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/jd1378/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/jd1378/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/jd1378/orgs",
|
|
"repos_url": "https://api.github.com/users/jd1378/repos",
|
|
"events_url": "https://api.github.com/users/jd1378/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/jd1378/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-20T19:37:43Z",
|
|
"updated_at": "2023-01-20T19:37:43Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "good to go I guess ?",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1398845380/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1399259106",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/7637#issuecomment-1399259106",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7637",
|
|
"id": 1399259106,
|
|
"node_id": "IC_kwDOBLftOs5TZv_i",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-01-21T14:11:57Z",
|
|
"updated_at": "2023-01-21T14:11:57Z",
|
|
"author_association": "OWNER",
|
|
"body": "Yes this is fine, and I'm going to create a pre-release so that other users can check too",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1399259106/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
}
|
|
]
|
|
} |