一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
1189 行
54 KiB
JSON
1189 行
54 KiB
JSON
{
|
|
"issue": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"repository_url": "https://api.github.com/repos/laurent22/joplin",
|
|
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/6722/labels{/name}",
|
|
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/6722/comments",
|
|
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/6722/events",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722",
|
|
"id": 1330786972,
|
|
"node_id": "PR_kwDOBLftOs48wljL",
|
|
"number": 6722,
|
|
"title": "CLI: Create Subnotebooks",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"labels": [
|
|
{
|
|
"id": 1095621255,
|
|
"node_id": "MDU6TGFiZWwxMDk1NjIxMjU1",
|
|
"url": "https://api.github.com/repos/laurent22/joplin/labels/cli",
|
|
"name": "cli",
|
|
"color": "ffc274",
|
|
"default": false,
|
|
"description": "CLI app specific issue"
|
|
}
|
|
],
|
|
"state": "closed",
|
|
"locked": true,
|
|
"assignee": null,
|
|
"assignees": [],
|
|
"milestone": null,
|
|
"comments": 24,
|
|
"created_at": "2022-08-06T16:01:00Z",
|
|
"updated_at": "2023-02-26T12:14:03Z",
|
|
"closed_at": "2023-02-26T12:13:46Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"sub_issues_summary": {
|
|
"total": 0,
|
|
"completed": 0,
|
|
"percent_completed": 0
|
|
},
|
|
"active_lock_reason": null,
|
|
"draft": false,
|
|
"pull_request": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/pulls/6722",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722",
|
|
"diff_url": "https://github.com/laurent22/joplin/pull/6722.diff",
|
|
"patch_url": "https://github.com/laurent22/joplin/pull/6722.patch",
|
|
"merged_at": "2023-02-26T12:13:46Z"
|
|
},
|
|
"body": "<!--\r\n\r\nPlease prefix the title with the platform you are targetting:\r\n\r\nHere are some examples of good titles:\r\n\r\n- Desktop: Resolves #123: Added new setting to change font\r\n- Mobile, Desktop: Fixes #456: Fixed config screen error\r\n- All: Resolves #777: Made synchronisation faster\r\n\r\nAnd here's an explanation of the title format:\r\n\r\n- \"Desktop\" for the Windows/macOS/Linux app (Electron app)\r\n- \"Mobile\" for the mobile app (or \"Android\" / \"iOS\" if the pull request only applies to one of the mobile platforms)\r\n- \"CLI\" for the CLI app\r\n\r\nIf it's two platforms, separate them with commas - \"Desktop, Mobile\" or if it's for all platforms, prefix with \"All\".\r\n\r\nIf it's not related to any platform (such as a translation, change to the documentation, etc.), simply don't add a platform.\r\n\r\nThen please append the issue that you've addressed or fixed. Use \"Resolves #123\" for new features or improvements and \"Fixes #123\" for bug fixes.\r\n\r\nAND PLEASE READ THE GUIDE: https://github.com/laurent22/joplin/blob/dev/CONTRIBUTING.md\r\n\r\n-->\r\n\r\n---\r\n\r\nUpdate: The purpose of this PR allows the user to create subnotebooks in the cli also independently of his currently selected notebook position \r\n\r\n---\r\n\r\nThis should be the last PR for #1728 \r\n(Pre PR request https://github.com/laurent22/joplin/pull/6671)\r\n\r\nI have port the `command-mkbook` to TypeScript, the reason is simple i wanted to try TypeScript and the opportunity was perfect. \r\nAll tests from the root folder are successful, exclude `cli-integration.sh` (read below).\r\nIn addition to this the possibility for creating of the sub-notebooks from different places was added.\r\n\r\nHowever, i would need a few tips for the tests.\r\n\r\n1. Is the `cli-integration.sh` old stuff? \r\n When I run it, i get an error message `Error: Cannot open database: Trying to access nodeSqlite before it has been set!!!:` \r\n This should have been fixed in the function\r\n https://github.com/laurent22/joplin/blob/a114e1b5f771538e8781d8da10abd97f07263a35/packages/lib/testing/test-utils.ts#L328 \r\n\r\n If i understand it right, it seems not to work since the commit `4a7746b` as\r\nthe package `shim` was added. Additing to it the shell script is not used\r\nanywhere (Maybe i am wrong with both).\r\n\r\n2. Exist one test function which i can use to test `mkbook` from the tui?\r\nIf not, i will use something similar to `cli-integration-tests` `execCommand` or\r\nthe `execCommand2`\r\n\r\n",
|
|
"closed_by": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/6722/reactions",
|
|
"total_count": 1,
|
|
"+1": 1,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/6722/timeline",
|
|
"performed_via_github_app": null,
|
|
"state_reason": null
|
|
},
|
|
"comments": [
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1211118306",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1211118306",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1211118306,
|
|
"node_id": "IC_kwDOBLftOs5IMDLi",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-08-10T18:44:32Z",
|
|
"updated_at": "2022-08-10T18:44:32Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "Can anyone answer my question above? Thanks in advance!\r\n@laurent22 @personalizedrefrigerator ",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1211118306/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1211870355",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1211870355",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1211870355,
|
|
"node_id": "IC_kwDOBLftOs5IO6yT",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-08-11T11:35:32Z",
|
|
"updated_at": "2022-08-11T11:35:32Z",
|
|
"author_association": "OWNER",
|
|
"body": "Also please remove the translation files. We do that in separate commits",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1211870355/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1211870951",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1211870951",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1211870951,
|
|
"node_id": "IC_kwDOBLftOs5IO67n",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-08-11T11:36:16Z",
|
|
"updated_at": "2022-08-11T11:36:16Z",
|
|
"author_association": "OWNER",
|
|
"body": "And you can ignore cli-integration.sh, it's deprecated",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1211870951/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1212002505",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1212002505",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1212002505,
|
|
"node_id": "IC_kwDOBLftOs5IPbDJ",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-08-11T13:38:25Z",
|
|
"updated_at": "2022-08-11T13:38:25Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "> Also please remove the translation files. We do that in separate commits\r\n\r\nDo i understand it right that i need to do a second PR with the modified translation files? Or will it be done in a different workflow for example from the maintainer side?",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1212002505/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1212064472",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1212064472",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1212064472,
|
|
"node_id": "IC_kwDOBLftOs5IPqLY",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-08-11T14:28:09Z",
|
|
"updated_at": "2022-08-11T14:28:09Z",
|
|
"author_association": "OWNER",
|
|
"body": "> Do i understand it right that i need to do a second PR with the modified translation files? Or will it be done in a different workflow for example from the maintainer side?\r\n\r\nYes from the maintainer side. We run a script that updates all translations in one commit",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1212064472/reactions",
|
|
"total_count": 1,
|
|
"+1": 1,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1214444067",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1214444067",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1214444067,
|
|
"node_id": "IC_kwDOBLftOs5IYvIj",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-08-14T20:31:50Z",
|
|
"updated_at": "2022-08-14T20:31:50Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "Tests are added now. Please give me feedback if i can improve anything in the\r\ntests.\r\n\r\nFrom my side both PRs (#6671, #6722) are ready for merge.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1214444067/reactions",
|
|
"total_count": 2,
|
|
"+1": 2,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1226860545",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1226860545",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1226860545,
|
|
"node_id": "IC_kwDOBLftOs5JIGgB",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-08-25T07:05:24Z",
|
|
"updated_at": "2022-08-25T07:05:24Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "@laurent22 Can you merge it or is anything from my side to do?\r\nPeople can test the pre-release maybe they will found some good improve ideas.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1226860545/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1231029752",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1231029752",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1231029752,
|
|
"node_id": "IC_kwDOBLftOs5JYAX4",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-08-30T01:11:29Z",
|
|
"updated_at": "2022-08-30T01:11:29Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "Test should also be fixed as well as @laurent22 improvement suggestions.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1231029752/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1263704341",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1263704341",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1263704341,
|
|
"node_id": "IC_kwDOBLftOs5LUpkV",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-09-30T15:15:11Z",
|
|
"updated_at": "2022-09-30T15:15:11Z",
|
|
"author_association": "OWNER",
|
|
"body": "The pull request top post should include a full description of the feature: what it does, how it does it, with examples of command lines. We don't read what's linked as the info is usually incomplete.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1263704341/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1264351841",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1264351841",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1264351841,
|
|
"node_id": "IC_kwDOBLftOs5LXHph",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-10-01T12:34:53Z",
|
|
"updated_at": "2022-10-17T09:08:16Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "> The pull request top post should include a full description of the feature: what it does, how it does it, with examples of command lines. We don't read what's linked as the info is usually incomplete.\r\n\r\nAfter a few conversations, I get the information that you are not reading what is linked....\r\nAs i have seen it, the contributing readme has beend adjusted yesterday. https://github.com/laurent22/joplin/commit/9781a33419e425748c3a59c2ffc3d65893419ac0 - Adjust the Description\r\n\r\n@laurent22 i have asked several questions https://github.com/laurent22/joplin/pull/6722#discussion_r976444547 to which I would need an answer, so than i can continue...",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1264351841/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1267135873",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1267135873",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1267135873,
|
|
"node_id": "IC_kwDOBLftOs5LhvWB",
|
|
"user": {
|
|
"login": "charlescochran",
|
|
"id": 77219451,
|
|
"node_id": "MDQ6VXNlcjc3MjE5NDUx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/77219451?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/charlescochran",
|
|
"html_url": "https://github.com/charlescochran",
|
|
"followers_url": "https://api.github.com/users/charlescochran/followers",
|
|
"following_url": "https://api.github.com/users/charlescochran/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/charlescochran/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/charlescochran/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/charlescochran/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/charlescochran/orgs",
|
|
"repos_url": "https://api.github.com/users/charlescochran/repos",
|
|
"events_url": "https://api.github.com/users/charlescochran/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/charlescochran/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-10-04T14:55:44Z",
|
|
"updated_at": "2022-10-04T14:55:44Z",
|
|
"author_association": "NONE",
|
|
"body": "Still looking forward to this feature! As I understand it, you can only create sub-notebooks using the desktop version. I use the Android app and the CLI version but not the desktop version, so this is rather inconvenient.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1267135873/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1296362256",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1296362256",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1296362256,
|
|
"node_id": "IC_kwDOBLftOs5NROsQ",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-10-30T22:12:03Z",
|
|
"updated_at": "2022-10-30T22:12:03Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "As I have not received a reply to my [message](https://github.com/laurent22/joplin/pull/6722#discussion_r976444547) regarding a decision. I am removing the tests to speed up the CI pipeline as I described in Solution 1.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1296362256/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1304402311",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1304402311",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1304402311,
|
|
"node_id": "IC_kwDOBLftOs5Nv5mH",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-11-05T04:33:24Z",
|
|
"updated_at": "2022-11-05T04:33:24Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "Should be done now - tests have run cleanly. ",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1304402311/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1321281090",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1321281090",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1321281090,
|
|
"node_id": "IC_kwDOBLftOs5OwSZC",
|
|
"user": {
|
|
"login": "charlescochran",
|
|
"id": 77219451,
|
|
"node_id": "MDQ6VXNlcjc3MjE5NDUx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/77219451?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/charlescochran",
|
|
"html_url": "https://github.com/charlescochran",
|
|
"followers_url": "https://api.github.com/users/charlescochran/followers",
|
|
"following_url": "https://api.github.com/users/charlescochran/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/charlescochran/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/charlescochran/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/charlescochran/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/charlescochran/orgs",
|
|
"repos_url": "https://api.github.com/users/charlescochran/repos",
|
|
"events_url": "https://api.github.com/users/charlescochran/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/charlescochran/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-11-20T23:54:56Z",
|
|
"updated_at": "2022-11-20T23:54:56Z",
|
|
"author_association": "NONE",
|
|
"body": "What is the next step for this?",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1321281090/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1321286125",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1321286125",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1321286125,
|
|
"node_id": "IC_kwDOBLftOs5OwTnt",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-11-21T00:11:05Z",
|
|
"updated_at": "2022-11-21T00:11:05Z",
|
|
"author_association": "OWNER",
|
|
"body": "Conflicts need to be fixed and branch rebased. Also run \"yarn run updateIgnored\" from root",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1321286125/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1322842305",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1322842305",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1322842305,
|
|
"node_id": "IC_kwDOBLftOs5O2PjB",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-11-22T00:37:08Z",
|
|
"updated_at": "2022-11-22T00:37:08Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "> Conflicts need to be fixed and branch rebased. Also run \"yarn run updateIgnored\" from root\r\n\r\nA merge instead of rebase was performed also `yarn run updateIgnored` from root\r\nTests have gone cleanly.\r\n\r\n@charlescochran thanks for keeping up!\r\n\r\n",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1322842305/reactions",
|
|
"total_count": 1,
|
|
"+1": 1,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361674831",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1361674831",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1361674831,
|
|
"node_id": "IC_kwDOBLftOs5RKYJP",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-12-21T17:02:13Z",
|
|
"updated_at": "2022-12-21T17:02:13Z",
|
|
"author_association": "OWNER",
|
|
"body": "recheck",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361674831/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361675162",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1361675162",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1361675162,
|
|
"node_id": "IC_kwDOBLftOs5RKYOa",
|
|
"user": {
|
|
"login": "github-actions[bot]",
|
|
"id": 41898282,
|
|
"node_id": "MDM6Qm90NDE4OTgyODI=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
|
|
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
|
|
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
|
|
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
|
|
"type": "Bot",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-12-21T17:02:30Z",
|
|
"updated_at": "2023-02-26T11:39:44Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361675162/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1367922850",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1367922850",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1367922850,
|
|
"node_id": "IC_kwDOBLftOs5RiNii",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-12-30T13:34:36Z",
|
|
"updated_at": "2022-12-30T13:34:36Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "I have read the CLA Document and I hereby sign the CLA",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1367922850/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1367924306",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1367924306",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1367924306,
|
|
"node_id": "IC_kwDOBLftOs5RiN5S",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2022-12-30T13:38:32Z",
|
|
"updated_at": "2022-12-30T13:38:32Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "@laurent22 You have really earned the beer / coffee! Please check again if the improvements fit like this.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1367924306/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1436994532",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1436994532",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1436994532,
|
|
"node_id": "IC_kwDOBLftOs5Vpsvk",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-02-20T13:04:17Z",
|
|
"updated_at": "2023-02-20T13:04:17Z",
|
|
"author_association": "OWNER",
|
|
"body": "@k33pn3xtlvl, we plan to release a new version 2.10 of the CLI app and hopefully your feature can be included. Please let me know if you need anything to get this completed!",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1436994532/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1438518308",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1438518308",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1438518308,
|
|
"node_id": "IC_kwDOBLftOs5Vvgwk",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-02-21T13:45:33Z",
|
|
"updated_at": "2023-02-21T13:45:33Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "I'm currently busy, I'll do it this week (probably today or the day after tomorrow).\r\nThanks for your support.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1438518308/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1439261692",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1439261692",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1439261692,
|
|
"node_id": "IC_kwDOBLftOs5VyWP8",
|
|
"user": {
|
|
"login": "k33pn3xtlvl",
|
|
"id": 81777961,
|
|
"node_id": "MDQ6VXNlcjgxNzc3OTYx",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/81777961?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/k33pn3xtlvl",
|
|
"html_url": "https://github.com/k33pn3xtlvl",
|
|
"followers_url": "https://api.github.com/users/k33pn3xtlvl/followers",
|
|
"following_url": "https://api.github.com/users/k33pn3xtlvl/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/k33pn3xtlvl/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/k33pn3xtlvl/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/k33pn3xtlvl/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/k33pn3xtlvl/orgs",
|
|
"repos_url": "https://api.github.com/users/k33pn3xtlvl/repos",
|
|
"events_url": "https://api.github.com/users/k33pn3xtlvl/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/k33pn3xtlvl/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-02-22T00:20:12Z",
|
|
"updated_at": "2023-02-22T00:20:12Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "@laurent22 Please look over it again. Thanks in advance! ",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1439261692/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445346034",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/6722#issuecomment-1445346034",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6722",
|
|
"id": 1445346034,
|
|
"node_id": "IC_kwDOBLftOs5WJjry",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2023-02-26T12:13:15Z",
|
|
"updated_at": "2023-02-26T12:13:15Z",
|
|
"author_association": "OWNER",
|
|
"body": "All good now, thanks @k33pn3xtlvl!",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445346034/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
}
|
|
]
|
|
} |