一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
272 行
11 KiB
JSON
272 行
11 KiB
JSON
{
|
|
"issue": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/14006",
|
|
"repository_url": "https://api.github.com/repos/laurent22/joplin",
|
|
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14006/labels{/name}",
|
|
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14006/comments",
|
|
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/14006/events",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/14006",
|
|
"id": 3771201070,
|
|
"node_id": "PR_kwDOBLftOs67BgQ_",
|
|
"number": 14006,
|
|
"title": "Desktop: Fixes #13029: Link to Note command not working via shortcut or command palette",
|
|
"user": {
|
|
"login": "mimo-to",
|
|
"id": 173403802,
|
|
"node_id": "U_kgDOClXumg",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/173403802?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/mimo-to",
|
|
"html_url": "https://github.com/mimo-to",
|
|
"followers_url": "https://api.github.com/users/mimo-to/followers",
|
|
"following_url": "https://api.github.com/users/mimo-to/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/mimo-to/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/mimo-to/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/mimo-to/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/mimo-to/orgs",
|
|
"repos_url": "https://api.github.com/users/mimo-to/repos",
|
|
"events_url": "https://api.github.com/users/mimo-to/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/mimo-to/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"labels": [],
|
|
"state": "closed",
|
|
"locked": false,
|
|
"assignees": [],
|
|
"milestone": null,
|
|
"comments": 2,
|
|
"created_at": "2025-12-30T20:18:41Z",
|
|
"updated_at": "2026-02-08T23:01:29Z",
|
|
"closed_at": "2026-02-08T23:01:16Z",
|
|
"assignee": null,
|
|
"author_association": "NONE",
|
|
"active_lock_reason": null,
|
|
"draft": false,
|
|
"pull_request": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/pulls/14006",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/14006",
|
|
"diff_url": "https://github.com/laurent22/joplin/pull/14006.diff",
|
|
"patch_url": "https://github.com/laurent22/joplin/pull/14006.patch",
|
|
"merged_at": null
|
|
},
|
|
"body": "### Summary\r\nFixes the **Link to Note** command not working when triggered via keyboard shortcut or command palette.\r\n\r\n### Problem\r\nThe **Link to Note** command did nothing when accessed through:\r\n- Keyboard shortcut (`Alt+Shift+L`)\r\n- Command palette (`Ctrl+Shift+P`)\r\n\r\nThe command only worked when invoked from the Tools menu.\r\n\r\n### Root cause\r\nThe command’s `enabledCondition` was too restrictive and disabled execution when triggered from modal contexts such as the command palette.\r\n\r\n### Fix\r\nUpdated the `enabledCondition` in \r\n`packages/app-desktop/gui/WindowCommandsAndDialogs/commands/linkToNote.ts` \r\nto allow execution when `gotoAnything` is visible, while still requiring:\r\n- a selected note\r\n- an active editor (Markdown or Rich Text)\r\n\r\nThis follows the same pattern used by other editor commands in the desktop codebase.\r\n\r\n### Manual testing\r\n- `Alt+Shift+L` opens **Link to Note**\r\n- `Ctrl+Shift+P` → **Link to Note** works\r\n- Tools menu behavior unchanged\r\n- Command remains blocked in non-editor modals (e.g. Settings)\r\n\r\nFixes #13029\r\n",
|
|
"closed_by": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/14006/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14006/timeline",
|
|
"performed_via_github_app": null,
|
|
"state_reason": null
|
|
},
|
|
"comments": [
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3700454092",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/14006#issuecomment-3700454092",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14006",
|
|
"id": 3700454092,
|
|
"node_id": "IC_kwDOBLftOs7ckHLM",
|
|
"user": {
|
|
"login": "github-actions[bot]",
|
|
"id": 41898282,
|
|
"node_id": "MDM6Qm90NDE4OTgyODI=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
|
|
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
|
|
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
|
|
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
|
|
"type": "Bot",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-12-30T20:18:52Z",
|
|
"updated_at": "2026-02-08T23:01:29Z",
|
|
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
|
|
"author_association": "CONTRIBUTOR",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3700454092/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": {
|
|
"id": 15368,
|
|
"client_id": "Iv1.05c79e9ad1f6bdfa",
|
|
"slug": "github-actions",
|
|
"node_id": "MDM6QXBwMTUzNjg=",
|
|
"owner": {
|
|
"login": "github",
|
|
"id": 9919,
|
|
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github",
|
|
"html_url": "https://github.com/github",
|
|
"followers_url": "https://api.github.com/users/github/followers",
|
|
"following_url": "https://api.github.com/users/github/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github/orgs",
|
|
"repos_url": "https://api.github.com/users/github/repos",
|
|
"events_url": "https://api.github.com/users/github/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github/received_events",
|
|
"type": "Organization",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"name": "GitHub Actions",
|
|
"description": "Automate your workflow from idea to production",
|
|
"external_url": "https://help.github.com/en/actions",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"created_at": "2018-07-30T09:30:17Z",
|
|
"updated_at": "2026-05-05T14:51:38Z",
|
|
"permissions": {
|
|
"actions": "write",
|
|
"administration": "read",
|
|
"artifact_metadata": "write",
|
|
"attestations": "write",
|
|
"checks": "write",
|
|
"code_quality": "write",
|
|
"contents": "write",
|
|
"copilot_requests": "write",
|
|
"deployments": "write",
|
|
"discussions": "write",
|
|
"issues": "write",
|
|
"merge_queues": "write",
|
|
"metadata": "read",
|
|
"models": "read",
|
|
"packages": "write",
|
|
"pages": "write",
|
|
"pull_requests": "write",
|
|
"repository_hooks": "write",
|
|
"repository_projects": "write",
|
|
"security_events": "write",
|
|
"statuses": "write",
|
|
"vulnerability_alerts": "read"
|
|
},
|
|
"events": [
|
|
"branch_protection_rule",
|
|
"check_run",
|
|
"check_suite",
|
|
"create",
|
|
"delete",
|
|
"deployment",
|
|
"deployment_status",
|
|
"discussion",
|
|
"discussion_comment",
|
|
"fork",
|
|
"gollum",
|
|
"issues",
|
|
"issue_comment",
|
|
"label",
|
|
"merge_group",
|
|
"milestone",
|
|
"page_build",
|
|
"public",
|
|
"pull_request",
|
|
"pull_request_review",
|
|
"pull_request_review_comment",
|
|
"push",
|
|
"registry_package",
|
|
"release",
|
|
"repository",
|
|
"repository_dispatch",
|
|
"status",
|
|
"watch",
|
|
"workflow_dispatch",
|
|
"workflow_run"
|
|
]
|
|
}
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3700461263",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/14006#issuecomment-3700461263",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14006",
|
|
"id": 3700461263,
|
|
"node_id": "IC_kwDOBLftOs7ckI7P",
|
|
"user": {
|
|
"login": "mimo-to",
|
|
"id": 173403802,
|
|
"node_id": "U_kgDOClXumg",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/173403802?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/mimo-to",
|
|
"html_url": "https://github.com/mimo-to",
|
|
"followers_url": "https://api.github.com/users/mimo-to/followers",
|
|
"following_url": "https://api.github.com/users/mimo-to/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/mimo-to/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/mimo-to/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/mimo-to/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/mimo-to/orgs",
|
|
"repos_url": "https://api.github.com/users/mimo-to/repos",
|
|
"events_url": "https://api.github.com/users/mimo-to/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/mimo-to/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-12-30T20:19:53Z",
|
|
"updated_at": "2025-12-30T20:19:53Z",
|
|
"body": "I have read the CLA Document and I hereby sign the CLA",
|
|
"author_association": "NONE",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3700461263/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
}
|
|
]
|
|
} |