一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
817 行
36 KiB
JSON
817 行
36 KiB
JSON
{
|
|
"issue": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"repository_url": "https://api.github.com/repos/laurent22/joplin",
|
|
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/9940/labels{/name}",
|
|
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/9940/comments",
|
|
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/9940/events",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940",
|
|
"id": 2135120920,
|
|
"node_id": "PR_kwDOBLftOs5m5sg7",
|
|
"number": 9940,
|
|
"title": "Server: Adding ARM64 support for both ARM servers and macOS",
|
|
"user": {
|
|
"login": "peterwilli",
|
|
"id": 1212814,
|
|
"node_id": "MDQ6VXNlcjEyMTI4MTQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1212814?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/peterwilli",
|
|
"html_url": "https://github.com/peterwilli",
|
|
"followers_url": "https://api.github.com/users/peterwilli/followers",
|
|
"following_url": "https://api.github.com/users/peterwilli/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/peterwilli/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/peterwilli/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/peterwilli/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/peterwilli/orgs",
|
|
"repos_url": "https://api.github.com/users/peterwilli/repos",
|
|
"events_url": "https://api.github.com/users/peterwilli/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/peterwilli/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"labels": [],
|
|
"state": "closed",
|
|
"locked": false,
|
|
"assignee": null,
|
|
"assignees": [],
|
|
"milestone": null,
|
|
"comments": 14,
|
|
"created_at": "2024-02-14T20:08:10Z",
|
|
"updated_at": "2024-03-02T15:46:39Z",
|
|
"closed_at": "2024-03-02T15:46:27Z",
|
|
"author_association": "NONE",
|
|
"sub_issues_summary": {
|
|
"total": 0,
|
|
"completed": 0,
|
|
"percent_completed": 0
|
|
},
|
|
"active_lock_reason": null,
|
|
"draft": false,
|
|
"pull_request": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/pulls/9940",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940",
|
|
"diff_url": "https://github.com/laurent22/joplin/pull/9940.diff",
|
|
"patch_url": "https://github.com/laurent22/joplin/pull/9940.patch",
|
|
"merged_at": null
|
|
},
|
|
"body": "This allows to build on arm64 + amd64, I use (and tested) this image to run on my Odroid ARM server.\r\n\r\nTest image is at: https://hub.docker.com/repository/docker/peterwilli/joplin-server/general (has both arm64 and amd64)\r\n\r\nHow to build an universal image: `docker buildx build -f Dockerfile.server --tag=peterwilli/joplin-server --platform=linux/arm64,linux/amd64 --push`\r\n\r\nOfcourse, replace `peterwilli/joplin-server` with your own tag.",
|
|
"closed_by": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/9940/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/9940/timeline",
|
|
"performed_via_github_app": null,
|
|
"state_reason": null
|
|
},
|
|
"comments": [
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1944512378",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1944512378",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1944512378,
|
|
"node_id": "IC_kwDOBLftOs5z5ud6",
|
|
"user": {
|
|
"login": "github-actions[bot]",
|
|
"id": 41898282,
|
|
"node_id": "MDM6Qm90NDE4OTgyODI=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
|
|
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
|
|
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
|
|
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
|
|
"type": "Bot",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-14T20:08:23Z",
|
|
"updated_at": "2024-03-02T15:46:39Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1944512378/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": {
|
|
"id": 15368,
|
|
"client_id": "Iv1.05c79e9ad1f6bdfa",
|
|
"slug": "github-actions",
|
|
"node_id": "MDM6QXBwMTUzNjg=",
|
|
"owner": {
|
|
"login": "github",
|
|
"id": 9919,
|
|
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github",
|
|
"html_url": "https://github.com/github",
|
|
"followers_url": "https://api.github.com/users/github/followers",
|
|
"following_url": "https://api.github.com/users/github/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github/orgs",
|
|
"repos_url": "https://api.github.com/users/github/repos",
|
|
"events_url": "https://api.github.com/users/github/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github/received_events",
|
|
"type": "Organization",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"name": "GitHub Actions",
|
|
"description": "Automate your workflow from idea to production",
|
|
"external_url": "https://help.github.com/en/actions",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"created_at": "2018-07-30T09:30:17Z",
|
|
"updated_at": "2025-03-07T16:35:00Z",
|
|
"permissions": {
|
|
"actions": "write",
|
|
"administration": "read",
|
|
"attestations": "write",
|
|
"checks": "write",
|
|
"contents": "write",
|
|
"deployments": "write",
|
|
"discussions": "write",
|
|
"issues": "write",
|
|
"merge_queues": "write",
|
|
"metadata": "read",
|
|
"models": "read",
|
|
"packages": "write",
|
|
"pages": "write",
|
|
"pull_requests": "write",
|
|
"repository_hooks": "write",
|
|
"repository_projects": "write",
|
|
"security_events": "write",
|
|
"statuses": "write",
|
|
"vulnerability_alerts": "read"
|
|
},
|
|
"events": [
|
|
"branch_protection_rule",
|
|
"check_run",
|
|
"check_suite",
|
|
"create",
|
|
"delete",
|
|
"deployment",
|
|
"deployment_status",
|
|
"discussion",
|
|
"discussion_comment",
|
|
"fork",
|
|
"gollum",
|
|
"issues",
|
|
"issue_comment",
|
|
"label",
|
|
"merge_group",
|
|
"milestone",
|
|
"page_build",
|
|
"project",
|
|
"project_card",
|
|
"project_column",
|
|
"public",
|
|
"pull_request",
|
|
"pull_request_review",
|
|
"pull_request_review_comment",
|
|
"push",
|
|
"registry_package",
|
|
"release",
|
|
"repository",
|
|
"repository_dispatch",
|
|
"status",
|
|
"watch",
|
|
"workflow_dispatch",
|
|
"workflow_run"
|
|
]
|
|
}
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1944512851",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1944512851",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1944512851,
|
|
"node_id": "IC_kwDOBLftOs5z5ulT",
|
|
"user": {
|
|
"login": "peterwilli",
|
|
"id": 1212814,
|
|
"node_id": "MDQ6VXNlcjEyMTI4MTQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1212814?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/peterwilli",
|
|
"html_url": "https://github.com/peterwilli",
|
|
"followers_url": "https://api.github.com/users/peterwilli/followers",
|
|
"following_url": "https://api.github.com/users/peterwilli/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/peterwilli/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/peterwilli/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/peterwilli/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/peterwilli/orgs",
|
|
"repos_url": "https://api.github.com/users/peterwilli/repos",
|
|
"events_url": "https://api.github.com/users/peterwilli/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/peterwilli/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-14T20:08:46Z",
|
|
"updated_at": "2024-02-14T20:08:46Z",
|
|
"author_association": "NONE",
|
|
"body": "I have read the CLA Document and I hereby sign the CLA",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1944512851/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1945089392",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1945089392",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1945089392,
|
|
"node_id": "IC_kwDOBLftOs5z77Vw",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-15T00:02:15Z",
|
|
"updated_at": "2024-02-15T00:02:15Z",
|
|
"author_association": "OWNER",
|
|
"body": "Thanks but could you explain the commit? I don't understand how adding packages related to jpg, gif or svg has something to do with supporting an arm64 version?",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1945089392/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1945595307",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1945595307",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1945595307,
|
|
"node_id": "IC_kwDOBLftOs5z922r",
|
|
"user": {
|
|
"login": "peterwilli",
|
|
"id": 1212814,
|
|
"node_id": "MDQ6VXNlcjEyMTI4MTQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1212814?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/peterwilli",
|
|
"html_url": "https://github.com/peterwilli",
|
|
"followers_url": "https://api.github.com/users/peterwilli/followers",
|
|
"following_url": "https://api.github.com/users/peterwilli/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/peterwilli/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/peterwilli/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/peterwilli/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/peterwilli/orgs",
|
|
"repos_url": "https://api.github.com/users/peterwilli/repos",
|
|
"events_url": "https://api.github.com/users/peterwilli/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/peterwilli/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-15T08:35:24Z",
|
|
"updated_at": "2024-02-15T08:36:23Z",
|
|
"author_association": "NONE",
|
|
"body": "> Thanks but could you explain the commit? I don't understand how adding packages related to jpg, gif or svg has something to do with supporting an arm64 version?\r\n\r\nFor some reason, when not adding these, I get an error, I think it has to do with the canvas npm package. Let me rebuild without them so I can replicate it for you.\r\n\r\nThe docker build was done at commit `d4b32d3a91008adbbde3cf26d293d8304742d07e`: [docker_build_error.log](https://github.com/laurent22/joplin/files/14293520/docker_build_error.log)\r\n\r\n\r\n",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1945595307/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1946214755",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1946214755",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1946214755,
|
|
"node_id": "IC_kwDOBLftOs50AOFj",
|
|
"user": {
|
|
"login": "ifurther",
|
|
"id": 55025025,
|
|
"node_id": "MDQ6VXNlcjU1MDI1MDI1",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/55025025?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/ifurther",
|
|
"html_url": "https://github.com/ifurther",
|
|
"followers_url": "https://api.github.com/users/ifurther/followers",
|
|
"following_url": "https://api.github.com/users/ifurther/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/ifurther/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/ifurther/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/ifurther/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/ifurther/orgs",
|
|
"repos_url": "https://api.github.com/users/ifurther/repos",
|
|
"events_url": "https://api.github.com/users/ifurther/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/ifurther/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-15T14:31:24Z",
|
|
"updated_at": "2024-02-15T14:31:24Z",
|
|
"author_association": "NONE",
|
|
"body": "@laurent22 It will build `canvas` because it could not provide the arm version.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1946214755/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1946301240",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1946301240",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1946301240,
|
|
"node_id": "IC_kwDOBLftOs50AjM4",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-15T15:16:01Z",
|
|
"updated_at": "2024-02-15T15:16:01Z",
|
|
"author_association": "OWNER",
|
|
"body": "Thanks for clarifying, that makes sense.\r\n\r\n> How to build an universal image: `docker buildx build -f Dockerfile.server --tag=peterwilli/joplin-server --platform=linux/arm64,linux/amd64 --push`\r\n\r\nSo does it mean if I change the command here, it will automatically create a universal image?\r\n\r\nhttps://github.com/laurent22/joplin/blob/4b520222edeb8fe3629bae2e22c3754318f81b66/packages/tools/buildServerDocker.ts#L60\r\n\r\nOr is there something more I would need to change?",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1946301240/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1948084534",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1948084534",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1948084534,
|
|
"node_id": "IC_kwDOBLftOs50HWk2",
|
|
"user": {
|
|
"login": "peterwilli",
|
|
"id": 1212814,
|
|
"node_id": "MDQ6VXNlcjEyMTI4MTQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1212814?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/peterwilli",
|
|
"html_url": "https://github.com/peterwilli",
|
|
"followers_url": "https://api.github.com/users/peterwilli/followers",
|
|
"following_url": "https://api.github.com/users/peterwilli/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/peterwilli/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/peterwilli/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/peterwilli/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/peterwilli/orgs",
|
|
"repos_url": "https://api.github.com/users/peterwilli/repos",
|
|
"events_url": "https://api.github.com/users/peterwilli/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/peterwilli/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-16T10:03:40Z",
|
|
"updated_at": "2024-02-16T10:03:40Z",
|
|
"author_association": "NONE",
|
|
"body": "> Or is there something more I would need to change?\r\n\r\nYou need Docker buildx command and if on X86, you need binfmt and the Qemu emulator: https://www.docker.com/blog/getting-started-with-docker-for-arm-on-linux/\r\n\r\nI haven't checked your code if there's CI or anything, but if there is I'm likely able to add the right dependencies!",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1948084534/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1948129876",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1948129876",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1948129876,
|
|
"node_id": "IC_kwDOBLftOs50HhpU",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-16T10:33:16Z",
|
|
"updated_at": "2024-02-16T10:33:16Z",
|
|
"author_association": "OWNER",
|
|
"body": "If you could advise on what dependencies might be needed that would be great. We indeed build the Docker image on CI from an `ubuntu-20.04` machine.\r\n\r\nWe then install these dependencies:\r\n\r\nhttps://github.com/laurent22/joplin/blob/7f50cb97873ce100119778f78b98196e4a71f0bc/.github/workflows/github-actions-main.yml#L50\r\n\r\nAnd then run the above mentioned command:\r\n\r\nhttps://github.com/laurent22/joplin/blob/4b520222edeb8fe3629bae2e22c3754318f81b66/packages/tools/buildServerDocker.ts#L60\r\n\r\nCan you see something in there that would need to be changed?",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1948129876/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1948364386",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1948364386",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1948364386,
|
|
"node_id": "IC_kwDOBLftOs50Ia5i",
|
|
"user": {
|
|
"login": "peterwilli",
|
|
"id": 1212814,
|
|
"node_id": "MDQ6VXNlcjEyMTI4MTQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1212814?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/peterwilli",
|
|
"html_url": "https://github.com/peterwilli",
|
|
"followers_url": "https://api.github.com/users/peterwilli/followers",
|
|
"following_url": "https://api.github.com/users/peterwilli/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/peterwilli/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/peterwilli/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/peterwilli/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/peterwilli/orgs",
|
|
"repos_url": "https://api.github.com/users/peterwilli/repos",
|
|
"events_url": "https://api.github.com/users/peterwilli/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/peterwilli/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-16T13:12:13Z",
|
|
"updated_at": "2024-02-16T13:12:48Z",
|
|
"author_association": "NONE",
|
|
"body": "> Can you see something in there that would need to be changed?\r\n\r\nI believe I do. Is there a way to verify this locally before I adjust my PR?\r\n\r\n[Edit: typo]",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1948364386/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1948438160",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1948438160",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1948438160,
|
|
"node_id": "IC_kwDOBLftOs50Is6Q",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-16T14:00:50Z",
|
|
"updated_at": "2024-02-16T14:00:50Z",
|
|
"author_association": "OWNER",
|
|
"body": "> I believe I do. Is there a way to verify this locally before I adjust my PR?\r\n\r\nVerifying this locally is hard, but you can add them to the PR and then it'll directly run on CI so we can check if all's good",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1948438160/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1948453399",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1948453399",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1948453399,
|
|
"node_id": "IC_kwDOBLftOs50IwoX",
|
|
"user": {
|
|
"login": "peterwilli",
|
|
"id": 1212814,
|
|
"node_id": "MDQ6VXNlcjEyMTI4MTQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1212814?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/peterwilli",
|
|
"html_url": "https://github.com/peterwilli",
|
|
"followers_url": "https://api.github.com/users/peterwilli/followers",
|
|
"following_url": "https://api.github.com/users/peterwilli/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/peterwilli/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/peterwilli/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/peterwilli/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/peterwilli/orgs",
|
|
"repos_url": "https://api.github.com/users/peterwilli/repos",
|
|
"events_url": "https://api.github.com/users/peterwilli/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/peterwilli/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-16T14:10:11Z",
|
|
"updated_at": "2024-02-16T14:10:27Z",
|
|
"author_association": "NONE",
|
|
"body": "I can try using act to run the actions locally (https://github.com/nektos/act), which always supported me well, I rather send it in correctly in 1 go 😆 \r\n",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1948453399/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1949917497",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1949917497",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1949917497,
|
|
"node_id": "IC_kwDOBLftOs50OWE5",
|
|
"user": {
|
|
"login": "ifurther",
|
|
"id": 55025025,
|
|
"node_id": "MDQ6VXNlcjU1MDI1MDI1",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/55025025?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/ifurther",
|
|
"html_url": "https://github.com/ifurther",
|
|
"followers_url": "https://api.github.com/users/ifurther/followers",
|
|
"following_url": "https://api.github.com/users/ifurther/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/ifurther/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/ifurther/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/ifurther/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/ifurther/orgs",
|
|
"repos_url": "https://api.github.com/users/ifurther/repos",
|
|
"events_url": "https://api.github.com/users/ifurther/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/ifurther/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-17T09:42:41Z",
|
|
"updated_at": "2024-02-17T09:42:41Z",
|
|
"author_association": "NONE",
|
|
"body": "@peterwilli docker publish the `docker/setup-buildx-action@v3` action, it will support action use buildx. I suggest install package to one line.\r\n\r\n@laurent22 Docker v23.0 use buildkit(buildx) to build container, `dockerCommand` should add `--platform=` for build different arch container.\r\n\r\n",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1949917497/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1960467557",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1960467557",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1960467557,
|
|
"node_id": "IC_kwDOBLftOs502lxl",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-22T22:51:39Z",
|
|
"updated_at": "2024-02-22T22:51:39Z",
|
|
"author_association": "OWNER",
|
|
"body": "> I can try using act to run the actions locally (https://github.com/nektos/act), which always supported me well, I rather send it in correctly in 1 go 😆\r\n\r\nThat sounds complex and it's definitely fine to use the PR CI for this purpose (I do it all the time!)",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1960467557/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974834080",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9940#issuecomment-1974834080",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9940",
|
|
"id": 1974834080,
|
|
"node_id": "IC_kwDOBLftOs51tZOg",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-03-02T15:46:27Z",
|
|
"updated_at": "2024-03-02T15:46:27Z",
|
|
"author_association": "OWNER",
|
|
"body": "I'm closing this for now as I'm trying to clear the PR backlog. I would be very keen to add support for ARM64 to the official Docker image though, so please let me know if you would like to continue looking into this and I'll reopen.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974834080/reactions",
|
|
"total_count": 1,
|
|
"+1": 1,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
}
|
|
]
|
|
} |