一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
542 行
25 KiB
JSON
542 行
25 KiB
JSON
{
|
|
"issue": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/12057",
|
|
"repository_url": "https://api.github.com/repos/laurent22/joplin",
|
|
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12057/labels{/name}",
|
|
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12057/comments",
|
|
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/12057/events",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/12057",
|
|
"id": 2974139065,
|
|
"node_id": "PR_kwDOBLftOs6RgDb9",
|
|
"number": 12057,
|
|
"title": "All: Updated translations for en_GB",
|
|
"user": {
|
|
"login": "tbjgolden",
|
|
"id": 8162045,
|
|
"node_id": "MDQ6VXNlcjgxNjIwNDU=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/8162045?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/tbjgolden",
|
|
"html_url": "https://github.com/tbjgolden",
|
|
"followers_url": "https://api.github.com/users/tbjgolden/followers",
|
|
"following_url": "https://api.github.com/users/tbjgolden/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/tbjgolden/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/tbjgolden/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/tbjgolden/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/tbjgolden/orgs",
|
|
"repos_url": "https://api.github.com/users/tbjgolden/repos",
|
|
"events_url": "https://api.github.com/users/tbjgolden/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/tbjgolden/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"labels": [],
|
|
"state": "closed",
|
|
"locked": false,
|
|
"assignee": null,
|
|
"assignees": [],
|
|
"milestone": null,
|
|
"comments": 8,
|
|
"created_at": "2025-04-05T11:29:24Z",
|
|
"updated_at": "2025-04-05T20:28:36Z",
|
|
"closed_at": "2025-04-05T13:56:14Z",
|
|
"author_association": "NONE",
|
|
"active_lock_reason": null,
|
|
"draft": false,
|
|
"pull_request": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/pulls/12057",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/12057",
|
|
"diff_url": "https://github.com/laurent22/joplin/pull/12057.diff",
|
|
"patch_url": "https://github.com/laurent22/joplin/pull/12057.patch",
|
|
"merged_at": null
|
|
},
|
|
"body": "- Added explicit confirmed translations for each\r\n- Only word changed was \"trash\" to \"bin\"\r\n\r\n> Windows UK: Recycle Bin, MacOS UK: Bin\r\n>\r\n> <img width=\"134\" alt=\"Screenshot 2025-04-05 at 12 27 07\" src=\"https://github.com/user-attachments/assets/2cc9bcdd-87e4-4750-b69e-2c7d5d811716\" />\r\n",
|
|
"closed_by": {
|
|
"login": "tbjgolden",
|
|
"id": 8162045,
|
|
"node_id": "MDQ6VXNlcjgxNjIwNDU=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/8162045?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/tbjgolden",
|
|
"html_url": "https://github.com/tbjgolden",
|
|
"followers_url": "https://api.github.com/users/tbjgolden/followers",
|
|
"following_url": "https://api.github.com/users/tbjgolden/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/tbjgolden/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/tbjgolden/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/tbjgolden/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/tbjgolden/orgs",
|
|
"repos_url": "https://api.github.com/users/tbjgolden/repos",
|
|
"events_url": "https://api.github.com/users/tbjgolden/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/tbjgolden/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/12057/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12057/timeline",
|
|
"performed_via_github_app": null,
|
|
"state_reason": null
|
|
},
|
|
"comments": [
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780673598",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2780673598",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057",
|
|
"id": 2780673598,
|
|
"node_id": "IC_kwDOBLftOs6lvbY-",
|
|
"user": {
|
|
"login": "github-actions[bot]",
|
|
"id": 41898282,
|
|
"node_id": "MDM6Qm90NDE4OTgyODI=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
|
|
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
|
|
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
|
|
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
|
|
"type": "Bot",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-04-05T11:29:35Z",
|
|
"updated_at": "2025-04-05T13:56:26Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780673598/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": {
|
|
"id": 15368,
|
|
"client_id": "Iv1.05c79e9ad1f6bdfa",
|
|
"slug": "github-actions",
|
|
"node_id": "MDM6QXBwMTUzNjg=",
|
|
"owner": {
|
|
"login": "github",
|
|
"id": 9919,
|
|
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github",
|
|
"html_url": "https://github.com/github",
|
|
"followers_url": "https://api.github.com/users/github/followers",
|
|
"following_url": "https://api.github.com/users/github/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github/orgs",
|
|
"repos_url": "https://api.github.com/users/github/repos",
|
|
"events_url": "https://api.github.com/users/github/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github/received_events",
|
|
"type": "Organization",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"name": "GitHub Actions",
|
|
"description": "Automate your workflow from idea to production",
|
|
"external_url": "https://help.github.com/en/actions",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"created_at": "2018-07-30T09:30:17Z",
|
|
"updated_at": "2025-03-07T16:35:00Z",
|
|
"permissions": {
|
|
"actions": "write",
|
|
"administration": "read",
|
|
"attestations": "write",
|
|
"checks": "write",
|
|
"contents": "write",
|
|
"deployments": "write",
|
|
"discussions": "write",
|
|
"issues": "write",
|
|
"merge_queues": "write",
|
|
"metadata": "read",
|
|
"models": "read",
|
|
"packages": "write",
|
|
"pages": "write",
|
|
"pull_requests": "write",
|
|
"repository_hooks": "write",
|
|
"repository_projects": "write",
|
|
"security_events": "write",
|
|
"statuses": "write",
|
|
"vulnerability_alerts": "read"
|
|
},
|
|
"events": [
|
|
"branch_protection_rule",
|
|
"check_run",
|
|
"check_suite",
|
|
"create",
|
|
"delete",
|
|
"deployment",
|
|
"deployment_status",
|
|
"discussion",
|
|
"discussion_comment",
|
|
"fork",
|
|
"gollum",
|
|
"issues",
|
|
"issue_comment",
|
|
"label",
|
|
"merge_group",
|
|
"milestone",
|
|
"page_build",
|
|
"project",
|
|
"project_card",
|
|
"project_column",
|
|
"public",
|
|
"pull_request",
|
|
"pull_request_review",
|
|
"pull_request_review_comment",
|
|
"push",
|
|
"registry_package",
|
|
"release",
|
|
"repository",
|
|
"repository_dispatch",
|
|
"status",
|
|
"watch",
|
|
"workflow_dispatch",
|
|
"workflow_run"
|
|
]
|
|
}
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780677909",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2780677909",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057",
|
|
"id": 2780677909,
|
|
"node_id": "IC_kwDOBLftOs6lvccV",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-04-05T11:42:11Z",
|
|
"updated_at": "2025-04-05T11:43:14Z",
|
|
"author_association": "OWNER",
|
|
"body": "There are technical challenges with changing \"trash\" to \"bin\" because the changes need to be made in the code, not the .po file. Also Apple has not localised \"Trash\" so it seems reasonable that we don't either. It annoys me a bit that everywhere in the code it will be called \"Trash\" (in functions, variables, etc.), but in user-facing strings it will be called \"Bin\".\r\n\r\nAnd so another issue is we don't modify en_GB.po because it's automatically generated from the code. If there are other strings that need to be changed, you would need to modify them in the .ts/.js files instead.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780677909/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780733298",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2780733298",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057",
|
|
"id": 2780733298,
|
|
"node_id": "IC_kwDOBLftOs6lvp9y",
|
|
"user": {
|
|
"login": "tbjgolden",
|
|
"id": 8162045,
|
|
"node_id": "MDQ6VXNlcjgxNjIwNDU=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/8162045?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/tbjgolden",
|
|
"html_url": "https://github.com/tbjgolden",
|
|
"followers_url": "https://api.github.com/users/tbjgolden/followers",
|
|
"following_url": "https://api.github.com/users/tbjgolden/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/tbjgolden/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/tbjgolden/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/tbjgolden/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/tbjgolden/orgs",
|
|
"repos_url": "https://api.github.com/users/tbjgolden/repos",
|
|
"events_url": "https://api.github.com/users/tbjgolden/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/tbjgolden/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-04-05T13:49:36Z",
|
|
"updated_at": "2025-04-05T13:49:36Z",
|
|
"author_association": "NONE",
|
|
"body": "I have read the CLA Document and I hereby sign the CLA",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780733298/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780736036",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2780736036",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057",
|
|
"id": 2780736036,
|
|
"node_id": "IC_kwDOBLftOs6lvqok",
|
|
"user": {
|
|
"login": "tbjgolden",
|
|
"id": 8162045,
|
|
"node_id": "MDQ6VXNlcjgxNjIwNDU=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/8162045?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/tbjgolden",
|
|
"html_url": "https://github.com/tbjgolden",
|
|
"followers_url": "https://api.github.com/users/tbjgolden/followers",
|
|
"following_url": "https://api.github.com/users/tbjgolden/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/tbjgolden/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/tbjgolden/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/tbjgolden/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/tbjgolden/orgs",
|
|
"repos_url": "https://api.github.com/users/tbjgolden/repos",
|
|
"events_url": "https://api.github.com/users/tbjgolden/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/tbjgolden/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-04-05T13:56:14Z",
|
|
"updated_at": "2025-04-05T13:56:14Z",
|
|
"author_association": "NONE",
|
|
"body": "> There are technical challenges with changing \"trash\" to \"bin\" because the changes need to be made in the code, not the .po file. Also Apple has not localised \"Trash\" so it seems reasonable that we don't either. It annoys me a bit that everywhere in the code it will be called \"Trash\" (in functions, variables, etc.), but in user-facing strings it will be called \"Bin\".\r\n\r\nApple has localised it, hence the screenshot provided. Maybe they haven't localised it consistently? I wonder if, as technical people, we use trash more than typical users because we need to refer to it within our code, e.g. `~/.Trash`? Thanks for explaining the technical and logistical issues.\r\n\r\nOn one hand it's a pure Americanism - I'd wager that if I asked the average non-coder Briton where their deleted files go to, they'd say the Recycle Bin/Bin. But can also see why it might be awkward to change it from Trash to Bin after it has already been released.\r\n\r\n> And so another issue is we don't modify en_GB.po because it's automatically generated from the code. If there are other strings that need to be changed, you would need to modify them in the .ts/.js files instead.\r\n\r\nAh was wondering about this and why they were empty but also marked as translated, apologies\r\n\r\nGiven all that will close the PR but happy to reopen if you want to revisit.\r\n",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780736036/reactions",
|
|
"total_count": 1,
|
|
"+1": 1,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780884686",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2780884686",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057",
|
|
"id": 2780884686,
|
|
"node_id": "IC_kwDOBLftOs6lwO7O",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-04-05T16:08:21Z",
|
|
"updated_at": "2025-04-05T16:08:21Z",
|
|
"author_association": "OWNER",
|
|
"body": "Thanks for the information. Not being a native speaker I had completely missed that \"trash\" wasn't British English. I guess we should indeed change it in this case but as mentioned the changes would need to be done on the source code itself.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780884686/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781032383",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2781032383",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057",
|
|
"id": 2781032383,
|
|
"node_id": "IC_kwDOBLftOs6lwy-_",
|
|
"user": {
|
|
"login": "tessus",
|
|
"id": 223439,
|
|
"node_id": "MDQ6VXNlcjIyMzQzOQ==",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/tessus",
|
|
"html_url": "https://github.com/tessus",
|
|
"followers_url": "https://api.github.com/users/tessus/followers",
|
|
"following_url": "https://api.github.com/users/tessus/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/tessus/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/tessus/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/tessus/orgs",
|
|
"repos_url": "https://api.github.com/users/tessus/repos",
|
|
"events_url": "https://api.github.com/users/tessus/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/tessus/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-04-05T18:29:51Z",
|
|
"updated_at": "2025-04-05T18:29:51Z",
|
|
"author_association": "COLLABORATOR",
|
|
"body": "@laurent22 isn't the trash/bin referenced by id rather than by name (when moving notes into it or any other operations that involve that object)? In such a case, changing the name, given that the aource code adds a translation point, should be trivial.\r\nIf not, using a special id, e.g. `deaddeaddeaddeaddeaddeaddeaddead` could be useful.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781032383/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781051613",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2781051613",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057",
|
|
"id": 2781051613,
|
|
"node_id": "IC_kwDOBLftOs6lw3rd",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-04-05T19:21:37Z",
|
|
"updated_at": "2025-04-05T19:21:37Z",
|
|
"author_association": "OWNER",
|
|
"body": "Yes it's referenced by an ID (`de1e7ede1e7ede1e7ede1e7ede1e7ede` for \"delete\") but it's more about going through all the files, and documentation too to update this. Then the .po files will also have to be updated so as not to invalidate all the translations. The trash folder is actually translated in other languages but it's just British English here that's special.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781051613/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781083305",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2781083305",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057",
|
|
"id": 2781083305,
|
|
"node_id": "IC_kwDOBLftOs6lw_ap",
|
|
"user": {
|
|
"login": "tessus",
|
|
"id": 223439,
|
|
"node_id": "MDQ6VXNlcjIyMzQzOQ==",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/tessus",
|
|
"html_url": "https://github.com/tessus",
|
|
"followers_url": "https://api.github.com/users/tessus/followers",
|
|
"following_url": "https://api.github.com/users/tessus/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/tessus/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/tessus/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/tessus/orgs",
|
|
"repos_url": "https://api.github.com/users/tessus/repos",
|
|
"events_url": "https://api.github.com/users/tessus/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/tessus/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-04-05T20:28:35Z",
|
|
"updated_at": "2025-04-05T20:28:35Z",
|
|
"author_association": "COLLABORATOR",
|
|
"body": "Ok, makes sense. Although the documentation should not be such an issue. Most people still understand `trash`, even though `bin` is used in their every day speech. In fact I suspect that more people who learn English as their second language will learn trash and not bin.\r\nDon't get me started on what Irish, Scots, Welsh, Canadians, Aussis, and Kiwis use in their respective dialects... ;-)\r\n\r\nAs long as it doesn't mean the exact opposite (which is unfortunately possible between US and British English) it should be fine. I think the docs should use the term `trash` anyway, since more people are familiar with it.\r\n\r\nChanging all the .po files is a hassle, but doable. I have done it a few times before. I would have to look into how many source files use `trash` though. I can have a look at it when I have a bit more time.\r\n\r\n\r\n\r\n ",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781083305/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
}
|
|
]
|
|
} |