wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/wh201906_62299611.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

774 行
41 KiB
JSON
原始文件 永久链接 Blame 文件历史

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/6865/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/6865/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/6865/events",
"html_url": "https://github.com/laurent22/joplin/pull/6865",
"id": 1377320489,
"node_id": "PR_kwDOBLftOs4_KneO",
"number": 6865,
"title": "Desktop: Fixes #6211: Try to replace the external link with internal link when attachment file is pasted in Markdown editor",
"user": {
"login": "wh201906",
"id": 62299611,
"node_id": "MDQ6VXNlcjYyMjk5NjEx",
"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wh201906",
"html_url": "https://github.com/wh201906",
"followers_url": "https://api.github.com/users/wh201906/followers",
"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
"organizations_url": "https://api.github.com/users/wh201906/orgs",
"repos_url": "https://api.github.com/users/wh201906/repos",
"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
"received_events_url": "https://api.github.com/users/wh201906/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": true,
"assignee": null,
"assignees": [],
"milestone": null,
"comments": 15,
"created_at": "2022-09-19T02:56:36Z",
"updated_at": "2023-01-12T00:38:20Z",
"closed_at": "2023-01-11T19:12:35Z",
"author_association": "CONTRIBUTOR",
"sub_issues_summary": {
"total": 0,
"completed": 0,
"percent_completed": 0
},
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/6865",
"html_url": "https://github.com/laurent22/joplin/pull/6865",
"diff_url": "https://github.com/laurent22/joplin/pull/6865.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/6865.patch",
"merged_at": "2023-01-11T19:12:35Z"
},
"body": "This will fix #6211. When the user copies an image from WYSIWYG editor, the clipboard will hold the absolute path of the image. The bug is when pasting it to Markdown editor, the absolute path will be pasted. Codes in this PR will try to replace the absolute path with the internal link if possible, just like copying and pasting an image in WYSIWYG editor.\r\nI tested it on Ubuntu and the bug is fixed.\r\nI have no idea about how to call an async function in an sync function. I just imitated the existing code. Please tell me if my code is wrong or not appropriate and I will fix it.",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/6865/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/6865/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1250517318",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1250517318",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1250517318,
"node_id": "IC_kwDOBLftOs5KiWFG",
"user": {
"login": "wh201906",
"id": 62299611,
"node_id": "MDQ6VXNlcjYyMjk5NjEx",
"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wh201906",
"html_url": "https://github.com/wh201906",
"followers_url": "https://api.github.com/users/wh201906/followers",
"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
"organizations_url": "https://api.github.com/users/wh201906/orgs",
"repos_url": "https://api.github.com/users/wh201906/repos",
"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
"received_events_url": "https://api.github.com/users/wh201906/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-09-19T03:08:13Z",
"updated_at": "2022-09-20T01:39:18Z",
"author_association": "CONTRIBUTOR",
"body": "~~I think editorPasteText() should run `editorRef.current.replaceSelection(clipboard.readText())` if the `replaceResourceExternalToInternalLinks()` returns an empty string or \"promise gets rejected\". But I don't know how to implement this.~~\r\nThe async function `replaceResourceExternalToInternalLinks(body, options)` just replace the specified text in body, so there is no need to add extra code to handle the empty result. Also, this function doesn't throw errors, and it doesn't call other async functions, so the promise is always resolved.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1250517318/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1250518879",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1250518879",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1250518879,
"node_id": "IC_kwDOBLftOs5KiWdf",
"user": {
"login": "wh201906",
"id": 62299611,
"node_id": "MDQ6VXNlcjYyMjk5NjEx",
"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wh201906",
"html_url": "https://github.com/wh201906",
"followers_url": "https://api.github.com/users/wh201906/followers",
"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
"organizations_url": "https://api.github.com/users/wh201906/orgs",
"repos_url": "https://api.github.com/users/wh201906/repos",
"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
"received_events_url": "https://api.github.com/users/wh201906/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-09-19T03:11:24Z",
"updated_at": "2022-09-20T09:58:53Z",
"author_association": "CONTRIBUTOR",
"body": "I don't know why the mobile build in CI failed. I did build the desktop version on Ubuntu and it works.\r\n\r\nHere are the logs for `Main (ubuntu-latest)`\r\n```\r\n2022-09-19T03:08:29.2443537Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;173mroot\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:.\u001b[39m \u001b[32mSTDOUT\u001b[39m \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: \u001b[38;5;214m[@joplin/app-mobile]:\u001b[39m [03:08:29] Starting 'encodeAssets'...\r\n2022-09-19T03:08:29.2517417Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;166m@joplin/\u001b[39m\u001b[38;5;173mapp-mobile\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:packages/app-mobile\u001b[39m \u001b[31mSTDERR\u001b[39m [03:08:29] 'encodeAssets' errored after 172 ms\r\n2022-09-19T03:08:29.2524888Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;166m@joplin/\u001b[39m\u001b[38;5;173mapp-mobile\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:packages/app-mobile\u001b[39m \u001b[31mSTDERR\u001b[39m [03:08:29] Error: ENOENT: no such file or directory, open '/home/runner/work/joplin/joplin/packages/app-mobile/tools/../pluginAssets/katex/fonts/KaTeX_SansSerif-Regular.woff2.base64.js'\r\n2022-09-19T03:08:29.2526917Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;166m@joplin/\u001b[39m\u001b[38;5;173mapp-mobile\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:packages/app-mobile\u001b[39m \u001b[31mSTDERR\u001b[39m [03:08:29] 'build' errored after 59 s\r\n2022-09-19T03:08:29.3598695Z \u001b[91m➤\u001b[39m YN0009: │ \u001b[38;5;166m@joplin/\u001b[39m\u001b[38;5;173mapp-mobile\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:packages/app-mobile\u001b[39m couldn't be built successfully (exit code 1, logs can be found here: \u001b[38;5;170m/tmp/xfs-ecaa907d/build.log\u001b[39m)\r\n2022-09-19T03:08:29.7358828Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;173mroot\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:.\u001b[39m \u001b[32mSTDOUT\u001b[39m \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: \u001b[38;5;214m[@joplin/app-mobile]:\u001b[39m [03:08:29] Finished 'encodeAssets' after 491 ms\r\n```\r\nHere are the logs for `ServerDockerImage (ubuntu-latest)`\r\n```\r\n2022-09-19T03:07:12.8879815Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;166m@joplin/\u001b[39m\u001b[38;5;173mapp-mobile\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:packages/app-mobile\u001b[39m \u001b[32mSTDOUT\u001b[39m [03:07:12] Starting 'encodeAssets'...\r\n2022-09-19T03:07:12.9020328Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;173mroot\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:.\u001b[39m \u001b[32mSTDOUT\u001b[39m \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: \u001b[38;5;214m[@joplin/app-mobile]:\u001b[39m [03:07:12] 'encodeAssets' errored after 122 ms\r\n2022-09-19T03:07:12.9029337Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;173mroot\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:.\u001b[39m \u001b[32mSTDOUT\u001b[39m \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: \u001b[38;5;214m[@joplin/app-mobile]:\u001b[39m [03:07:12] Error: EEXIST: file already exists, mkdir '/home/runner/work/joplin/joplin/packages/app-mobile/pluginAssets/katex/fonts'\r\n2022-09-19T03:07:12.9040022Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;173mroot\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:.\u001b[39m \u001b[32mSTDOUT\u001b[39m \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: \u001b[38;5;214m[@joplin/app-mobile]:\u001b[39m [03:07:12] 'build' errored after 55 s\r\n2022-09-19T03:07:12.9816960Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;173mroot\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:.\u001b[39m \u001b[32mSTDOUT\u001b[39m \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: \u001b[38;5;214m[@joplin/app-mobile]:\u001b[39m Process exited (exit code 1), completed in 1m 2s\r\n2022-09-19T03:07:12.9822495Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;173mroot\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:.\u001b[39m \u001b[32mSTDOUT\u001b[39m \u001b[91m➤\u001b[39m YN0000: The command failed for workspaces that are depended upon by other workspaces; can't satisfy the dependency graph\r\n2022-09-19T03:07:12.9829183Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;173mroot\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:.\u001b[39m \u001b[32mSTDOUT\u001b[39m \u001b[91m➤\u001b[39m YN0000: Failed with errors in 1m 4s\r\n2022-09-19T03:07:13.1364868Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;173mroot\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:.\u001b[39m \u001b[31mSTDERR\u001b[39m [03:07:13] 'build' errored after 1.12 min\r\n2022-09-19T03:07:13.1365889Z \u001b[94m➤\u001b[39m \u001b[90mYN0000\u001b[39m: │ \u001b[38;5;173mroot\u001b[39m\u001b[38;5;111m@\u001b[39m\u001b[38;5;111mworkspace:.\u001b[39m \u001b[31mSTDERR\u001b[39m [03:07:13] Error: Command failed with exit code 1: yarn run buildSequential\r\n```\r\nThey all have the similar errors when doing `encodeAssets` in the building process of `app-mobile`, but I didn't touch the code in `app-mobile`. Maybe we need to re-run the jobs",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1250518879/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1251301429",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1251301429",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1251301429,
"node_id": "IC_kwDOBLftOs5KlVg1",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-09-19T17:06:36Z",
"updated_at": "2022-09-19T17:06:36Z",
"author_association": "OWNER",
"body": "We need a clear description of what's been fixed, and a working pr.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1251301429/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1251317831",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1251317831",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1251317831,
"node_id": "IC_kwDOBLftOs5KlZhH",
"user": {
"login": "wh201906",
"id": 62299611,
"node_id": "MDQ6VXNlcjYyMjk5NjEx",
"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wh201906",
"html_url": "https://github.com/wh201906",
"followers_url": "https://api.github.com/users/wh201906/followers",
"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
"organizations_url": "https://api.github.com/users/wh201906/orgs",
"repos_url": "https://api.github.com/users/wh201906/repos",
"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
"received_events_url": "https://api.github.com/users/wh201906/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-09-19T17:21:44Z",
"updated_at": "2022-09-20T01:07:19Z",
"author_association": "CONTRIBUTOR",
"body": "> We need a clear description of what's been fixed, and a working pr.\r\n\r\nI have updated the title and description of this PR. Are they correct?\r\nI think the PR is working now since it passed all CI test, and I have tested the functionality of it on Ubuntu and it works as expected.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1251317831/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1264394455",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1264394455",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1264394455,
"node_id": "IC_kwDOBLftOs5LXSDX",
"user": {
"login": "wh201906",
"id": 62299611,
"node_id": "MDQ6VXNlcjYyMjk5NjEx",
"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wh201906",
"html_url": "https://github.com/wh201906",
"followers_url": "https://api.github.com/users/wh201906/followers",
"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
"organizations_url": "https://api.github.com/users/wh201906/orgs",
"repos_url": "https://api.github.com/users/wh201906/repos",
"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
"received_events_url": "https://api.github.com/users/wh201906/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-10-01T15:13:44Z",
"updated_at": "2022-10-01T15:13:44Z",
"author_association": "CONTRIBUTOR",
"body": "@laurent22 Hi. Is there anything I need to do?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1264394455/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279839900",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1279839900",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1279839900,
"node_id": "IC_kwDOBLftOs5MSM6c",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-10-15T22:01:46Z",
"updated_at": "2022-10-15T22:01:46Z",
"author_association": "OWNER",
"body": "Thanks for fixing this, and I think that's the right fix, but I wonder if we want to support this kind of copy and paste between wysiwyg and markdown editor? Lots of other things probably don't work, such as copying tables, and it feels like the solution is simply to not do it.\r\n\r\nWhy would someone want to copy from one editor to another anyway? Why not stay on the same one? ",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279839900/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279880811",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1279880811",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1279880811,
"node_id": "IC_kwDOBLftOs5MSW5r",
"user": {
"login": "wh201906",
"id": 62299611,
"node_id": "MDQ6VXNlcjYyMjk5NjEx",
"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wh201906",
"html_url": "https://github.com/wh201906",
"followers_url": "https://api.github.com/users/wh201906/followers",
"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
"organizations_url": "https://api.github.com/users/wh201906/orgs",
"repos_url": "https://api.github.com/users/wh201906/repos",
"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
"received_events_url": "https://api.github.com/users/wh201906/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-10-16T03:12:26Z",
"updated_at": "2022-10-16T03:15:55Z",
"author_association": "CONTRIBUTOR",
"body": "> but I wonder if we want to support this kind of copy and paste between wysiwyg and markdown editor?\r\n\r\nI guess this PR can be applied to more situations. Any external links referring to something in profile(resources) directory can be converted into the internal links.\r\n\r\n> Lots of other things probably don't work, such as copying tables\r\n\r\nI don't know why these things won't work after merging this PR. Could you please give me more information or examples? \r\nPlus, this PR is based on the behaviors of TinyMCE editor, as I mentioned in [this comment](https://github.com/laurent22/joplin/issues/6211#issuecomment-1250337502). If something doesn't work there, the TinyMCE editor should have the similar problem.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279880811/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279882035",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1279882035",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1279882035,
"node_id": "IC_kwDOBLftOs5MSXMz",
"user": {
"login": "wh201906",
"id": 62299611,
"node_id": "MDQ6VXNlcjYyMjk5NjEx",
"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wh201906",
"html_url": "https://github.com/wh201906",
"followers_url": "https://api.github.com/users/wh201906/followers",
"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
"organizations_url": "https://api.github.com/users/wh201906/orgs",
"repos_url": "https://api.github.com/users/wh201906/repos",
"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
"received_events_url": "https://api.github.com/users/wh201906/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-10-16T03:22:53Z",
"updated_at": "2022-10-16T03:49:21Z",
"author_association": "CONTRIBUTOR",
"body": "Another solution is to find the resource parts in the clipboard which look like `[...](...)`, then replace them only.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279882035/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279983808",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1279983808",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1279983808,
"node_id": "IC_kwDOBLftOs5MSwDA",
"user": {
"login": "tomasz1986",
"id": 5626656,
"node_id": "MDQ6VXNlcjU2MjY2NTY=",
"avatar_url": "https://avatars.githubusercontent.com/u/5626656?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tomasz1986",
"html_url": "https://github.com/tomasz1986",
"followers_url": "https://api.github.com/users/tomasz1986/followers",
"following_url": "https://api.github.com/users/tomasz1986/following{/other_user}",
"gists_url": "https://api.github.com/users/tomasz1986/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tomasz1986/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tomasz1986/subscriptions",
"organizations_url": "https://api.github.com/users/tomasz1986/orgs",
"repos_url": "https://api.github.com/users/tomasz1986/repos",
"events_url": "https://api.github.com/users/tomasz1986/events{/privacy}",
"received_events_url": "https://api.github.com/users/tomasz1986/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-10-16T14:44:24Z",
"updated_at": "2022-10-16T14:47:23Z",
"author_association": "NONE",
"body": "> Why would someone want to copy from one editor to another anyway? Why not stay on the same one?\r\n\r\nI mainly use WYSIWYG, but I also switch between the two when I want to add formatting that isn't available in the top bar (e.g. H4/5/6 or straight-up HTML code), and if I happen to have an image that I want to insert copied to clipboard already, I may as well paste it in the Markdown editor as well.\r\n\r\nThe main problem here is probably that the non-technical user isn't really aware that such a link is absolute and device specific. With tables and other complex formatting, the user can immediately see when something isn't right. With these images, it's only after they've synced their data to another machine when they discover that the links are broken. In the worst case scenario, at that point they may not even have the original images anymore.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279983808/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1304697815",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1304697815",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1304697815,
"node_id": "IC_kwDOBLftOs5NxBvX",
"user": {
"login": "wh201906",
"id": 62299611,
"node_id": "MDQ6VXNlcjYyMjk5NjEx",
"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wh201906",
"html_url": "https://github.com/wh201906",
"followers_url": "https://api.github.com/users/wh201906/followers",
"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
"organizations_url": "https://api.github.com/users/wh201906/orgs",
"repos_url": "https://api.github.com/users/wh201906/repos",
"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
"received_events_url": "https://api.github.com/users/wh201906/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-11-06T02:16:41Z",
"updated_at": "2022-11-06T02:21:44Z",
"author_association": "CONTRIBUTOR",
"body": "I think this problem is easier to be triggered than we expected. \r\nhttps://discourse.joplinapp.org/t/why-is-github-issues-long-left-to-be-answered/25993\r\nhttps://discourse.joplinapp.org/t/disappearing-accessories-a-serious-functional-defect/28082\r\nI'm willing to renovate this PR if the current version would cause any problem.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1304697815/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1304738273",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1304738273",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1304738273,
"node_id": "IC_kwDOBLftOs5NxLnh",
"user": {
"login": "tomasz1986",
"id": 5626656,
"node_id": "MDQ6VXNlcjU2MjY2NTY=",
"avatar_url": "https://avatars.githubusercontent.com/u/5626656?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tomasz1986",
"html_url": "https://github.com/tomasz1986",
"followers_url": "https://api.github.com/users/tomasz1986/followers",
"following_url": "https://api.github.com/users/tomasz1986/following{/other_user}",
"gists_url": "https://api.github.com/users/tomasz1986/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tomasz1986/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tomasz1986/subscriptions",
"organizations_url": "https://api.github.com/users/tomasz1986/orgs",
"repos_url": "https://api.github.com/users/tomasz1986/repos",
"events_url": "https://api.github.com/users/tomasz1986/events{/privacy}",
"received_events_url": "https://api.github.com/users/tomasz1986/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-11-06T07:36:09Z",
"updated_at": "2022-11-06T07:37:13Z",
"author_association": "NONE",
"body": "> I think this problem is easier to be triggered than we expected.\r\n\r\nYeah, and I think another aspect which hasn't been pointed enough yet is that this issue literally causes the user to lose data (e.g. when they no longer have access to the original device and/or file). The user who has lost data due to a bug is usually a very unhappy user.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1304738273/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361674948",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1361674948",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1361674948,
"node_id": "IC_kwDOBLftOs5RKYLE",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-21T17:02:20Z",
"updated_at": "2022-12-21T17:02:20Z",
"author_association": "OWNER",
"body": "recheck",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361674948/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361675305",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1361675305",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1361675305,
"node_id": "IC_kwDOBLftOs5RKYQp",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-21T17:02:36Z",
"updated_at": "2022-12-21T17:40:10Z",
"author_association": "CONTRIBUTOR",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361675305/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361737493",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1361737493",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1361737493,
"node_id": "IC_kwDOBLftOs5RKncV",
"user": {
"login": "wh201906",
"id": 62299611,
"node_id": "MDQ6VXNlcjYyMjk5NjEx",
"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wh201906",
"html_url": "https://github.com/wh201906",
"followers_url": "https://api.github.com/users/wh201906/followers",
"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
"organizations_url": "https://api.github.com/users/wh201906/orgs",
"repos_url": "https://api.github.com/users/wh201906/repos",
"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
"received_events_url": "https://api.github.com/users/wh201906/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-21T17:39:56Z",
"updated_at": "2022-12-21T17:39:56Z",
"author_association": "CONTRIBUTOR",
"body": "I have read the CLA Document and I hereby sign the CLA",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361737493/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1379362073",
"html_url": "https://github.com/laurent22/joplin/pull/6865#issuecomment-1379362073",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6865",
"id": 1379362073,
"node_id": "IC_kwDOBLftOs5SN2UZ",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-11T19:12:27Z",
"updated_at": "2023-01-11T19:12:27Z",
"author_association": "OWNER",
"body": "Ok let's merge, this change seems relatively safe and still an improvement. Thanks for implementing this @wh201906!",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1379362073/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接