一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
602 行
26 KiB
JSON
602 行
26 KiB
JSON
{
|
|
"issue": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/9803",
|
|
"repository_url": "https://api.github.com/repos/laurent22/joplin",
|
|
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/9803/labels{/name}",
|
|
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/9803/comments",
|
|
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/9803/events",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803",
|
|
"id": 2107082024,
|
|
"node_id": "PR_kwDOBLftOs5laQ8a",
|
|
"number": 9803,
|
|
"title": "Mobile: Resolves #8639: implement callback url",
|
|
"user": {
|
|
"login": "tiberiusteng",
|
|
"id": 661892,
|
|
"node_id": "MDQ6VXNlcjY2MTg5Mg==",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/661892?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/tiberiusteng",
|
|
"html_url": "https://github.com/tiberiusteng",
|
|
"followers_url": "https://api.github.com/users/tiberiusteng/followers",
|
|
"following_url": "https://api.github.com/users/tiberiusteng/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/tiberiusteng/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/tiberiusteng/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/tiberiusteng/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/tiberiusteng/orgs",
|
|
"repos_url": "https://api.github.com/users/tiberiusteng/repos",
|
|
"events_url": "https://api.github.com/users/tiberiusteng/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/tiberiusteng/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"labels": [
|
|
{
|
|
"id": 1079605111,
|
|
"node_id": "MDU6TGFiZWwxMDc5NjA1MTEx",
|
|
"url": "https://api.github.com/repos/laurent22/joplin/labels/mobile",
|
|
"name": "mobile",
|
|
"color": "ffc274",
|
|
"default": false,
|
|
"description": "All mobile platforms"
|
|
}
|
|
],
|
|
"state": "closed",
|
|
"locked": false,
|
|
"assignee": null,
|
|
"assignees": [],
|
|
"milestone": null,
|
|
"comments": 9,
|
|
"created_at": "2024-01-30T06:51:55Z",
|
|
"updated_at": "2024-06-15T08:58:35Z",
|
|
"closed_at": "2024-06-15T08:58:23Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"sub_issues_summary": {
|
|
"total": 0,
|
|
"completed": 0,
|
|
"percent_completed": 0
|
|
},
|
|
"active_lock_reason": null,
|
|
"draft": false,
|
|
"pull_request": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/pulls/9803",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803",
|
|
"diff_url": "https://github.com/laurent22/joplin/pull/9803.diff",
|
|
"patch_url": "https://github.com/laurent22/joplin/pull/9803.patch",
|
|
"merged_at": "2024-06-15T08:58:23Z"
|
|
},
|
|
"body": "Resolves #8639, #9204\r\n\r\n* Added \"Copy external link\" menu items to note, folder and tag view of mobile app.\r\n* Implement callback url handling in mobile app\r\n\r\nThis can be used to create QR code stickers / NFC tags with joplin links, opening corresponding note/tag/folder when scanning them with an android device installed Joplin and containing that note/tag/folder.\r\n\r\nInvalid IDs are not specially handled for now, and will open into an empty page (in my opinion this behavior is better than keep displaying an irrevalent item, but it's certainly better to implement a 'not found' page later, this is currently out of my React ability so it could need others help to implement this)\r\n\r\nBuild, run in Android/iOS, create some notes, folders, tags and then run following command on dev machine (get those URLs from the new \"Copy external link\" menu items of the app):\r\n```\r\n> npx uri-scheme open \"joplin://x-callback-url/openNote?id=c800f58c4e374c8da1970bacf498325a\" --android\r\n> npx uri-scheme open \"joplin://x-callback-url/openFolder?id=7628016b49054dcaa5338c79fcb20ea1\" --android\r\n> npx uri-scheme open \"joplin://x-callback-url/openTag?id=06bfddc7b63e4432baa1f94076257645\" --android\r\n```\r\nYou can also use some QR code generator to generate tags containing those URLs (some generators in URL mode will complain these URLs as invalid, in such case please try `free text` mode), then use Camera/barcode scanner app to scan it, and then touch the scanned URL or tap 'open in browser' button, it should bring up Joplin and directly go to corresponding item.\r\n\r\nTested on Pixel 7 Pro (Android 14), iPad mini 5 (iOS 16.6).\r\n",
|
|
"closed_by": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/9803/reactions",
|
|
"total_count": 5,
|
|
"+1": 4,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 1,
|
|
"eyes": 0
|
|
},
|
|
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/9803/timeline",
|
|
"performed_via_github_app": null,
|
|
"state_reason": null
|
|
},
|
|
"comments": [
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1916185726",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803#issuecomment-1916185726",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9803",
|
|
"id": 1916185726,
|
|
"node_id": "IC_kwDOBLftOs5yNqx-",
|
|
"user": {
|
|
"login": "github-actions[bot]",
|
|
"id": 41898282,
|
|
"node_id": "MDM6Qm90NDE4OTgyODI=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
|
|
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
|
|
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
|
|
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
|
|
"type": "Bot",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-01-30T06:52:10Z",
|
|
"updated_at": "2024-06-15T08:58:35Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1916185726/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": {
|
|
"id": 15368,
|
|
"client_id": "Iv1.05c79e9ad1f6bdfa",
|
|
"slug": "github-actions",
|
|
"node_id": "MDM6QXBwMTUzNjg=",
|
|
"owner": {
|
|
"login": "github",
|
|
"id": 9919,
|
|
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github",
|
|
"html_url": "https://github.com/github",
|
|
"followers_url": "https://api.github.com/users/github/followers",
|
|
"following_url": "https://api.github.com/users/github/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github/orgs",
|
|
"repos_url": "https://api.github.com/users/github/repos",
|
|
"events_url": "https://api.github.com/users/github/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github/received_events",
|
|
"type": "Organization",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"name": "GitHub Actions",
|
|
"description": "Automate your workflow from idea to production",
|
|
"external_url": "https://help.github.com/en/actions",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"created_at": "2018-07-30T09:30:17Z",
|
|
"updated_at": "2025-03-07T16:35:00Z",
|
|
"permissions": {
|
|
"actions": "write",
|
|
"administration": "read",
|
|
"attestations": "write",
|
|
"checks": "write",
|
|
"contents": "write",
|
|
"deployments": "write",
|
|
"discussions": "write",
|
|
"issues": "write",
|
|
"merge_queues": "write",
|
|
"metadata": "read",
|
|
"models": "read",
|
|
"packages": "write",
|
|
"pages": "write",
|
|
"pull_requests": "write",
|
|
"repository_hooks": "write",
|
|
"repository_projects": "write",
|
|
"security_events": "write",
|
|
"statuses": "write",
|
|
"vulnerability_alerts": "read"
|
|
},
|
|
"events": [
|
|
"branch_protection_rule",
|
|
"check_run",
|
|
"check_suite",
|
|
"create",
|
|
"delete",
|
|
"deployment",
|
|
"deployment_status",
|
|
"discussion",
|
|
"discussion_comment",
|
|
"fork",
|
|
"gollum",
|
|
"issues",
|
|
"issue_comment",
|
|
"label",
|
|
"merge_group",
|
|
"milestone",
|
|
"page_build",
|
|
"project",
|
|
"project_card",
|
|
"project_column",
|
|
"public",
|
|
"pull_request",
|
|
"pull_request_review",
|
|
"pull_request_review_comment",
|
|
"push",
|
|
"registry_package",
|
|
"release",
|
|
"repository",
|
|
"repository_dispatch",
|
|
"status",
|
|
"watch",
|
|
"workflow_dispatch",
|
|
"workflow_run"
|
|
]
|
|
}
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1916186035",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803#issuecomment-1916186035",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9803",
|
|
"id": 1916186035,
|
|
"node_id": "IC_kwDOBLftOs5yNq2z",
|
|
"user": {
|
|
"login": "tiberiusteng",
|
|
"id": 661892,
|
|
"node_id": "MDQ6VXNlcjY2MTg5Mg==",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/661892?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/tiberiusteng",
|
|
"html_url": "https://github.com/tiberiusteng",
|
|
"followers_url": "https://api.github.com/users/tiberiusteng/followers",
|
|
"following_url": "https://api.github.com/users/tiberiusteng/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/tiberiusteng/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/tiberiusteng/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/tiberiusteng/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/tiberiusteng/orgs",
|
|
"repos_url": "https://api.github.com/users/tiberiusteng/repos",
|
|
"events_url": "https://api.github.com/users/tiberiusteng/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/tiberiusteng/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-01-30T06:52:29Z",
|
|
"updated_at": "2024-01-30T06:52:29Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "I have read the CLA Document and I hereby sign the CLA",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1916186035/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1919120341",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803#issuecomment-1919120341",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9803",
|
|
"id": 1919120341,
|
|
"node_id": "IC_kwDOBLftOs5yY3PV",
|
|
"user": {
|
|
"login": "tiberiusteng",
|
|
"id": 661892,
|
|
"node_id": "MDQ6VXNlcjY2MTg5Mg==",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/661892?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/tiberiusteng",
|
|
"html_url": "https://github.com/tiberiusteng",
|
|
"followers_url": "https://api.github.com/users/tiberiusteng/followers",
|
|
"following_url": "https://api.github.com/users/tiberiusteng/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/tiberiusteng/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/tiberiusteng/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/tiberiusteng/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/tiberiusteng/orgs",
|
|
"repos_url": "https://api.github.com/users/tiberiusteng/repos",
|
|
"events_url": "https://api.github.com/users/tiberiusteng/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/tiberiusteng/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-01-31T13:38:05Z",
|
|
"updated_at": "2024-01-31T13:38:05Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "the CI job \"Build macOS M1 / Main (pull_request)\" seems timed out on downloading yarn cache, please re-run it for me since I don't have permission, thanks",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1919120341/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1927354283",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803#issuecomment-1927354283",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9803",
|
|
"id": 1927354283,
|
|
"node_id": "IC_kwDOBLftOs5y4Rer",
|
|
"user": {
|
|
"login": "personalizedrefrigerator",
|
|
"id": 46334387,
|
|
"node_id": "MDQ6VXNlcjQ2MzM0Mzg3",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/personalizedrefrigerator",
|
|
"html_url": "https://github.com/personalizedrefrigerator",
|
|
"followers_url": "https://api.github.com/users/personalizedrefrigerator/followers",
|
|
"following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs",
|
|
"repos_url": "https://api.github.com/users/personalizedrefrigerator/repos",
|
|
"events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-02-05T16:14:18Z",
|
|
"updated_at": "2024-02-05T16:18:30Z",
|
|
"author_association": "COLLABORATOR",
|
|
"body": "We're [getting close to the feature freeze](https://joplinapp.org/help/about/release_cycle), so, for now, I'm marking this as targeting version 2.15. (Though, arguably, this feature doesn't impact existing functionality. As such, it could also make sense to target 2.14, at least the internal/non-GUI part.)\r\n\r\nThank you for implementing this!",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1927354283/reactions",
|
|
"total_count": 2,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 2,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2158821754",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803#issuecomment-2158821754",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9803",
|
|
"id": 2158821754,
|
|
"node_id": "IC_kwDOBLftOs6ArQF6",
|
|
"user": {
|
|
"login": "personalizedrefrigerator",
|
|
"id": 46334387,
|
|
"node_id": "MDQ6VXNlcjQ2MzM0Mzg3",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/personalizedrefrigerator",
|
|
"html_url": "https://github.com/personalizedrefrigerator",
|
|
"followers_url": "https://api.github.com/users/personalizedrefrigerator/followers",
|
|
"following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs",
|
|
"repos_url": "https://api.github.com/users/personalizedrefrigerator/repos",
|
|
"events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-06-10T16:28:32Z",
|
|
"updated_at": "2024-06-10T16:29:16Z",
|
|
"author_association": "COLLABORATOR",
|
|
"body": "@laurent22 I think this feature would be nice to have. Would you be open to a version of this PR without the UI changes? If necessary, the ability to get an external link could be added through a plugin.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2158821754/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2159912042",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803#issuecomment-2159912042",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9803",
|
|
"id": 2159912042,
|
|
"node_id": "IC_kwDOBLftOs6AvaRq",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-06-11T06:39:18Z",
|
|
"updated_at": "2024-06-11T06:39:18Z",
|
|
"author_association": "OWNER",
|
|
"body": "Yes for now a version without UI change would be acceptable. I think the problem with the UI changes is that it requires some refactoring and clean up first",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2159912042/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2168562162",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803#issuecomment-2168562162",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9803",
|
|
"id": 2168562162,
|
|
"node_id": "IC_kwDOBLftOs6BQaHy",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-06-14T18:35:08Z",
|
|
"updated_at": "2024-06-14T18:35:08Z",
|
|
"author_association": "OWNER",
|
|
"body": "@tiberiusteng, apologies for letting this PR in limbo for so long. Would you be ok with removing the UI changes as personalizedrefrigerator suggested? And then we can merge it in 3.0. For the UI changes we'll see this some other time or indeed it could be a plugin.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2168562162/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2168568261",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803#issuecomment-2168568261",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9803",
|
|
"id": 2168568261,
|
|
"node_id": "IC_kwDOBLftOs6BQbnF",
|
|
"user": {
|
|
"login": "tiberiusteng",
|
|
"id": 661892,
|
|
"node_id": "MDQ6VXNlcjY2MTg5Mg==",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/661892?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/tiberiusteng",
|
|
"html_url": "https://github.com/tiberiusteng",
|
|
"followers_url": "https://api.github.com/users/tiberiusteng/followers",
|
|
"following_url": "https://api.github.com/users/tiberiusteng/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/tiberiusteng/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/tiberiusteng/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/tiberiusteng/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/tiberiusteng/orgs",
|
|
"repos_url": "https://api.github.com/users/tiberiusteng/repos",
|
|
"events_url": "https://api.github.com/users/tiberiusteng/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/tiberiusteng/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-06-14T18:40:03Z",
|
|
"updated_at": "2024-06-14T18:40:03Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "Sure, I'll try to remove the UI modifications.",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2168568261/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2169225323",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/9803#issuecomment-2169225323",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9803",
|
|
"id": 2169225323,
|
|
"node_id": "IC_kwDOBLftOs6BS8Br",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-06-15T08:58:19Z",
|
|
"updated_at": "2024-06-15T08:58:19Z",
|
|
"author_association": "OWNER",
|
|
"body": "Great, thanks @tiberiusteng!",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2169225323/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
}
|
|
]
|
|
} |